Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document how to land ICU floating patches #26108

Closed
srl295 opened this issue Feb 14, 2019 · 2 comments
Closed

docs: document how to land ICU floating patches #26108

srl295 opened this issue Feb 14, 2019 · 2 comments
Assignees
@srl295
Labels
doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Feb 14, 2019

per: #26090 (review)

document how to land floating patches to ICU.

// @refack
@srl295 srl295 self-assigned this Feb 14, 2019
@srl295 srl295 added doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation. labels Feb 14, 2019
@richardlau
Copy link
Member

@srl295 I think the most logical place for this is https://github.com/nodejs/node/tree/master/doc/guides -- See the existing maintaining-npm.md and maintaining-V8.md for what's currently documented for npm and V8.

@srl295
Copy link
Member Author

srl295 commented Nov 22, 2019

@richardlau yes, though there's already tools/icu/README.md. I think it makes sense to move some content from the README into a new guide.

@srl295 srl295 mentioned this issue Nov 22, 2019
Closed
3 tasks
MylesBorins pushed a commit to srl295/node that referenced this issue Nov 27, 2019
@srl295 @vsemozhetbyt @MylesBorins
doc,deps: document how to maintain ICU in Node.js
24cd1c5 
- update v8 guide to mention ICU
- move content from the tools/icu/README.md but leave a pointer

Fixes: nodejs#26108
Co-Authored-By: Vse Mozhet Byt <[email protected]>
PR-URL: nodejs#30607
addaleax pushed a commit that referenced this issue Nov 30, 2019
@srl295 @addaleax
doc,deps: document how to maintain ICU in Node.js
b67759a 
- update v8 guide to mention ICU
- move content from the tools/icu/README.md but leave a pointer

Fixes: #26108
Co-Authored-By: Vse Mozhet Byt <[email protected]>
PR-URL: #30607

Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc,deps: document how to maintain ICU in Node.js srl295/node
2 participants
@srl295 @richardlau