Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: parallel test runner is not ^C interruptable #260

Closed
bnoordhuis opened this issue Jan 8, 2015 · 2 comments
Closed

test: parallel test runner is not ^C interruptable #260

bnoordhuis opened this issue Jan 8, 2015 · 2 comments

Comments

@bnoordhuis
Copy link
Member

Seen on OS X and Linux. Without the -J flag, things work fine.

$ make test
make -C out BUILDTYPE=Release V=1
make[1]: Entering directory '/home/bnoordhuis/src/v1.x/out'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/bnoordhuis/src/v1.x/out'
ln -fs out/Release/iojs iojs
/usr/bin/python tools/test.py --mode=release message parallel sequential -J
[00:13|%  12|+ 101|-   0]: release test-crypto-domains^C Interrupted
=== release test-crypto-domains ===
Path: parallel/test-crypto-domains
Command: out/Release/iojs /home/bnoordhuis/src/v1.x/test/parallel/test-crypto-domains.js
--- CRASHED ---
=== release test-cluster-worker-no-exit ===
Path: parallel/test-cluster-worker-no-exit
Command: out/Release/iojs /home/bnoordhuis/src/v1.x/test/parallel/test-cluster-worker-no-exit.js
--- CRASHED ---
=== release test-dgram-implicit-bind ===                   ^C
Path: parallel/test-dgram-implicit-bind
Command: out/Release/iojs /home/bnoordhuis/src/v1.x/test/parallel/test-dgram-implicit-bind.js
--- CRASHED ---
=== release test-dgram-multicast-setTTL ===                   ^C
Path: parallel/test-dgram-multicast-setTTL
Command: out/Release/iojs /home/bnoordhuis/src/v1.x/test/parallel/test-dgram-multicast-setTTL.js
--- CRASHED ---
# etc.

/cc @indutny @trevnorris

chrisdickinson added a commit that referenced this issue Jan 9, 2015
use a threading.Event instead of a boolean attribute.

PR-URL: #277
Fixes: #260
Reviewed-By: Ben Noordhuis <[email protected]>
@indutny
Copy link
Member

indutny commented Jan 10, 2015

Could be closed?

@bnoordhuis
Copy link
Member Author

Yes, it's fixed per commit 12912c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants