Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-tls-ticket-cluster.js is flaky #2510

Closed
rvagg opened this issue Aug 24, 2015 · 10 comments · Fixed by #52431
Closed

test-tls-ticket-cluster.js is flaky #2510

rvagg opened this issue Aug 24, 2015 · 10 comments · Fixed by #52431
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform.

Comments

@rvagg
Copy link
Member

rvagg commented Aug 24, 2015

@indutny you should probably take this one since it's your test and fairly new. It's being quite flaky in builds, e.g.

from the V8 4.5 upgrade @ #2509 on Win 2008: https://jenkins-iojs.nodesource.com/job/node-test-commit-windows/258/nodes=win2008r2/console
from the libuv 1.7.1 update: #2310 (comment)
@mscdex mscdex added test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. labels Aug 24, 2015
@joaocgreis joaocgreis mentioned this issue Aug 25, 2015
Closed
@whitlockjc
Copy link
Contributor

Mind adding the windows label?

@Trott
Copy link
Member

Trott commented Oct 22, 2015

It looks like this test has stopped being flaky. It's possible some stuff has moved around on CI such that I'm not finding it, but I don't see any recent failures for it on win2008r2. Everything is from August.

Trott added a commit to Trott/io.js that referenced this issue Oct 22, 2015
@Trott
test: remove flaky flag on test-tls-ticket-cluster
edf9f02 
The test hasn't failed since August so the flaky designation can be
removed.

Ref: nodejs#2510
@jbergstroem
Copy link
Member

@Trott you want to be looking at the fanned job: https://ci.nodejs.org/job/node-test-binary-windows/

@Trott Trott mentioned this issue Oct 22, 2015
Closed
@Trott
Copy link
Member

Trott commented Oct 22, 2015

It's possible some stuff has moved around on CI such that I'm not finding it,

Yup. (Thanks, @jbergstroem.)

@Trott Trott added the windows Issues and PRs related to the Windows platform. label Oct 23, 2015
@Trott Trott mentioned this issue Oct 24, 2015
Closed
@Trott
Copy link
Member

Trott commented Oct 24, 2015

I think #3510 will fix this.

Trott added a commit to Trott/io.js that referenced this issue Oct 24, 2015
@Trott
lib: fix cluster handle leak
d47a15b 
It is possible to cause a resource leak in SharedHandle if a worker is
added after all other workers have been removed. This commit fixes the
leak.

Fixes: nodejs#2510
Trott added a commit to Trott/io.js that referenced this issue Oct 26, 2015
@Trott
lib: fix cluster handle leak
136c273 
It is possible to cause a resource leak in SharedHandle if a worker is
added after all other workers have been removed. This commit fixes the
leak.

Fixes: nodejs#2510
PR-URL: nodejs#3510
Trott added a commit to Trott/io.js that referenced this issue Oct 26, 2015
@Trott
lib: fix cluster handle leak
5d5b5fc 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: nodejs#2510
PR-URL: nodejs#3510
Reviewed-By: Ben Noordhuis <[email protected]>
@Trott Trott closed this as completed in da21dba Oct 27, 2015
Trott added a commit that referenced this issue Oct 28, 2015
@Trott @jasnell
lib: fix cluster handle leak
e4417a1 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: #2510
PR-URL: #3510
Reviewed-By: Ben Noordhuis <[email protected]>
rvagg pushed a commit to rvagg/io.js that referenced this issue Oct 29, 2015
@Trott @rvagg
lib: fix cluster handle leak
1929d5b 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: nodejs#2510
PR-URL: nodejs#3510
Reviewed-By: Ben Noordhuis <[email protected]>
Trott added a commit that referenced this issue Oct 29, 2015
@Trott @jasnell
lib: fix cluster handle leak
2109708 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: #2510
PR-URL: #3510
Reviewed-By: Ben Noordhuis <[email protected]>
@mscdex
Copy link
Contributor

mscdex commented Dec 28, 2015

@Trott Can test-tls-ticket-cluster be removed from the flaky tests now since #3510 or is it still currently flaky?

@Trott
Copy link
Member

Trott commented Dec 28, 2015

@mscdex Yes, I believe it can be removed from the list of flaky tests. (And if I'm wrong about that, it will become apparent...)

mscdex pushed a commit to mscdex/io.js that referenced this issue Feb 9, 2016
@Trott @mscdex
lib: fix cluster handle leak
dd257b5 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: nodejs#2510
PR-URL: nodejs#3510
Reviewed-By: Ben Noordhuis <[email protected]>
mscdex pushed a commit that referenced this issue Feb 11, 2016
@Trott @mscdex
lib: fix cluster handle leak
5f58ead 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: #2510
PR-URL: #5152
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Feb 11, 2016
@Trott
lib: fix cluster handle leak
d421e85 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: #2510
PR-URL: #5152
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@santigimeno santigimeno mentioned this issue Feb 26, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Feb 26, 2016
@Trott
test: remove flaky designation from fixed tests
6a39eb3 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: nodejs#2510
Refs: nodejs#2660
@Trott Trott mentioned this issue Feb 26, 2016
Closed
Trott added a commit to Trott/io.js that referenced this issue Feb 29, 2016
@Trott
test: remove flaky designation from fixed tests
4d6b4c3 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: nodejs#2510
Refs: nodejs#2660
PR-URL: nodejs#5459
Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this issue Mar 2, 2016
@Trott @Fishrock123
test: remove flaky designation from fixed tests
0ebbf6c 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
@Trott
test: remove flaky designation from fixed tests
48d069d 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@Trott
test: remove flaky designation from fixed tests
f242e62 
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <[email protected]>
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
@Trott @jBarz
lib: fix cluster handle leak
2ef8298 
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: nodejs/node#2510
PR-URL: nodejs/node#5152
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung joyeecheung reopened this Aug 18, 2023
@joyeecheung
Copy link
Member

Still flaky according to nodejs/reliability#640

@marco-ippolito
Copy link
Member

marco-ippolito commented Dec 16, 2023 •
edited
Loading

Last time it has been marked as flaky 2023-11-09, more than 1 month ago.
Query https://github.com/search?q=repo%3Anodejs%2Freliability+test-tls-ticket-cluster&type=issues&s=created&o=desc
Seems to be fixed, closing

@targos
Copy link
Member

targos commented Mar 7, 2024

Still flaky in 2024: https://ci.nodejs.org/job/node-test-commit-linuxone/42549/
https://github.com/nodejs/reliability/issues?q=is%3Aissue+is%3Aopen+test-tls-ticket-cluster

@targos targos reopened this Mar 7, 2024
@huseyinacacak-janea huseyinacacak-janea mentioned this issue Apr 9, 2024
Merged
aduh95 pushed a commit that referenced this issue Apr 29, 2024
@huseyinacacak-janea @aduh95
test: fix test-tls-ticket-cluster.js
c8c6173 
Ensured connection end is initiated by worker (server)

Fixes: #2510
PR-URL: #52431
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this issue May 2, 2024
@huseyinacacak-janea @marco-ippolito
test: fix test-tls-ticket-cluster.js
e0fa990 
Ensured connection end is initiated by worker (server)

Fixes: #2510
PR-URL: #52431
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this issue May 3, 2024
@huseyinacacak-janea @marco-ippolito
test: fix test-tls-ticket-cluster.js
c871fad 
Ensured connection end is initiated by worker (server)

Fixes: #2510
PR-URL: #52431
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-tls-ticket-cluster.js JaneaSystems/node
lib: fix cluster handle leak Trott/io.js
8 participants
@mscdex @whitlockjc @jbergstroem @rvagg @Trott @targos @joyeecheung @marco-ippolito