Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test test-dgram-multicast-multi-process #2474

Closed
joaocgreis opened this issue Aug 20, 2015 · 9 comments
Closed

Investigate flaky test test-dgram-multicast-multi-process #2474

joaocgreis opened this issue Aug 20, 2015 · 9 comments
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:

@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Aug 20, 2015
@joaocgreis
Copy link
Member Author

It seems that this test always fails on the platforms where it fails, and always passes where it passes.

@bnoordhuis
Copy link
Member

What do the firewall rules on those machines look like? They should allow for multicast traffic.

@rvagg
Copy link
Member

rvagg commented Aug 21, 2015

if they are failing on pi1 but passing on pi2 then it won't be networking specifics, not only are they on exactly the same network but they are even running the same OS & OS config

@Trott
Copy link
Member

Trott commented Nov 24, 2015

This test is in test/internet which doesn't get run during ordinary CI runs. Does it get run during release builds or something?

Possibly related: I can't get the stress test to run this test on FreeBSD. Might have something to do with the recent changes to the FreeBSD hosts. Here's one of my attempts: https://ci.nodejs.org/job/node-stress-single-test/33/

@jbergstroem
Copy link
Member

@Trott the problem is that there's no nodes in the -32 and -64 labels. I've updated it so it includes the new bots.

@Trott
Copy link
Member

Trott commented Nov 25, 2015

@jbergstroem Thanks!

The test usually passes on the FreBSD bot but it is flaky. https://ci.nodejs.org/job/node-stress-single-test/46/nodes=freebsd102-64/console

@Trott
Copy link
Member

Trott commented Nov 26, 2015

I think I've figured this one out. Here's a refactored run in progress: https://ci.nodejs.org/job/node-stress-single-test/53/nodes=freebsd102-64/console As of this writing, 1040 successful runs with no failures. I have it set for 9999.

@Trott
Copy link
Member

Trott commented Nov 26, 2015

Because I'm an optimist, here is a run on Raspberry Pi as well. (That's the other platform cited in this issue.) For the Pi, I'm only running it 999 times because life is short and you can spend all of it waiting for Pi stress tests to finish if you're not careful. https://ci.nodejs.org/job/node-stress-single-test/54/nodes=pi1-raspbian-wheezy/console

@Trott
Copy link
Member

Trott commented Nov 26, 2015

PR: #4042

Trott added a commit to Trott/io.js that referenced this issue Nov 28, 2015
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: nodejs#2474
@Trott Trott closed this as completed in b3313aa Dec 1, 2015
Trott added a commit that referenced this issue Dec 5, 2015
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: #2474
PR-URL: #4042
Reviewed-By: Ben Noordhuis <[email protected]>
Trott added a commit that referenced this issue Dec 29, 2015
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: #2474
PR-URL: #4042
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: #2474
PR-URL: #4042
Reviewed-By: Ben Noordhuis <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: nodejs#2474
PR-URL: nodejs#4042
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants