-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky test test-dgram-multicast-multi-process #2474
Comments
It seems that this test always fails on the platforms where it fails, and always passes where it passes. |
What do the firewall rules on those machines look like? They should allow for multicast traffic. |
if they are failing on pi1 but passing on pi2 then it won't be networking specifics, not only are they on exactly the same network but they are even running the same OS & OS config |
This test is in Possibly related: I can't get the stress test to run this test on FreeBSD. Might have something to do with the recent changes to the FreeBSD hosts. Here's one of my attempts: https://ci.nodejs.org/job/node-stress-single-test/33/ |
@Trott the problem is that there's no nodes in the |
@jbergstroem Thanks! The test usually passes on the FreBSD bot but it is flaky. https://ci.nodejs.org/job/node-stress-single-test/46/nodes=freebsd102-64/console |
I think I've figured this one out. Here's a refactored run in progress: https://ci.nodejs.org/job/node-stress-single-test/53/nodes=freebsd102-64/console As of this writing, 1040 successful runs with no failures. I have it set for 9999. |
Because I'm an optimist, here is a run on Raspberry Pi as well. (That's the other platform cited in this issue.) For the Pi, I'm only running it 999 times because life is short and you can spend all of it waiting for Pi stress tests to finish if you're not careful. https://ci.nodejs.org/job/node-stress-single-test/54/nodes=pi1-raspbian-wheezy/console |
PR: #4042 |
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: nodejs#2474
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: #2474 PR-URL: #4042 Reviewed-By: Ben Noordhuis <[email protected]>
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: #2474 PR-URL: #4042 Reviewed-By: Ben Noordhuis <[email protected]>
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: #2474 PR-URL: #4042 Reviewed-By: Ben Noordhuis <[email protected]>
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: nodejs#2474 PR-URL: nodejs#4042 Reviewed-By: Ben Noordhuis <[email protected]>
Examples of failures:
pi1-raspbian-wheezy
freebsd101-32
freebsd101-64
The text was updated successfully, but these errors were encountered: