Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: ICU shrinker needs to adapt to new output path #23245

Closed
srl295 opened this issue Oct 3, 2018 · 4 comments
Closed

tools: ICU shrinker needs to adapt to new output path #23245

srl295 opened this issue Oct 3, 2018 · 4 comments
Assignees
@srl295
Labels
doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Oct 3, 2018 •
edited
Loading

  • Version:v11.0.0-pre
  • Platform:all
  • Subsystem:tools

The location of the ICU small datafile changed from out/Release/gen/icutmp to out/Release/obj/gen/icutmp

Not critical (because there's a workaround), but would be nice to fix the default. Supports #23244
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Oct 3, 2018
@srl295 srl295 self-assigned this Oct 3, 2018
@srl295
Copy link
Member Author

srl295 commented Oct 3, 2018

also, #22450 moved configure to configure.py, so fix the docs also

@srl295 srl295 added the doc Issues and PRs related to the documentations. label Oct 3, 2018
@refack
Copy link
Contributor

refack commented Oct 3, 2018

@srl295 Do the docs refer to this value:

def configure_intl(o):
  icus = [
    {
      'url': 'https://sourceforge.net/projects/icu/files/ICU4C/62.1/icu4c-62_1-src.zip',
      'md5': '408854f7b9b58311b68fab4b4dfc80be',
    },
  ]

I would actually believe is would be easy to read it from a file (say tools/icu/current_ver.dep)?

@refack
Copy link
Contributor

refack commented Oct 4, 2018 •
edited
Loading

BTW @srl295 did you mean to post this and #23244 as PRs or issues?

@srl295
Copy link
Member Author

srl295 commented Oct 4, 2018

@refack issues. PR coming soon, but 63.1 is not final yet.

@srl295 srl295 mentioned this issue Oct 4, 2018
Merged
3 tasks
@refack refack mentioned this issue Oct 4, 2018
Merged
3 tasks
srl295 added a commit to srl295/node that referenced this issue Oct 4, 2018
@srl295
tools: fix ICU shrinker and docs
a4ffa0c 
- tools: path to ICU datafile moved
- docs: configure is now configure.py

Fixes: nodejs#23245

PR-URL: nodejs#23266
Reviewed-By: Refael Ackermann <[email protected]>
targos pushed a commit that referenced this issue Oct 5, 2018
@srl295 @targos
tools: fix ICU shrinker and docs
f2c90d0 
- tools: path to ICU datafile moved
- docs: configure is now configure.py

Fixes: #23245

PR-URL: #23266
Reviewed-By: Refael Ackermann <[email protected]>
targos pushed a commit that referenced this issue Oct 7, 2018
@srl295 @targos
tools: fix ICU shrinker and docs
1010ef5 
- tools: path to ICU datafile moved
- docs: configure is now configure.py

Fixes: #23245

PR-URL: #23266
Reviewed-By: Refael Ackermann <[email protected]>
refack added a commit to refack/node that referenced this issue Oct 12, 2018
@refack
tools,icu: read full ICU version info from file
be346d9 
* ATM on every ICU version bump we need to update these data. Reading
  it from a file makes it independant of `configre.py` changes.
* Update guide.

PR-URL: nodejs#23269
Refs: nodejs#23245
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this issue Oct 12, 2018
@refack @targos
tools,icu: read full ICU version info from file
9cc73d3 
* ATM on every ICU version bump we need to update these data. Reading
  it from a file makes it independant of `configre.py` changes.
* Update guide.

PR-URL: #23269
Refs: #23245
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
jasnell pushed a commit that referenced this issue Oct 17, 2018
@srl295 @jasnell
tools: fix ICU shrinker and docs
b4da667 
- tools: path to ICU datafile moved
- docs: configure is now configure.py

Fixes: #23245

PR-URL: #23266
Reviewed-By: Refael Ackermann <[email protected]>
jasnell pushed a commit that referenced this issue Oct 17, 2018
@refack @jasnell
tools,icu: read full ICU version info from file
47af3a1 
* ATM on every ICU version bump we need to update these data. Reading
  it from a file makes it independant of `configre.py` changes.
* Update guide.

PR-URL: #23269
Refs: #23245
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this issue Oct 30, 2018
@refack @MylesBorins
tools,icu: read full ICU version info from file
4344667 
* ATM on every ICU version bump we need to update these data. Reading
  it from a file makes it independant of `configre.py` changes.
* Update guide.

PR-URL: #23269
Refs: #23245
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@refack @rvagg
tools,icu: read full ICU version info from file
83bbd5e 
* ATM on every ICU version bump we need to update these data. Reading
  it from a file makes it independant of `configre.py` changes.
* Update guide.

PR-URL: #23269
Refs: #23245
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 29, 2018
@refack @MylesBorins
tools,icu: read full ICU version info from file
cae703c 
* ATM on every ICU version bump we need to update these data. Reading
  it from a file makes it independant of `configre.py` changes.
* Update guide.

PR-URL: #23269
Refs: #23245
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@refack @srl295