Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream.pipeline does not re-emit errors without callback #20303

Closed
phated opened this issue Apr 25, 2018 · 4 comments
Closed

Stream.pipeline does not re-emit errors without callback #20303

phated opened this issue Apr 25, 2018 · 4 comments
Labels
stream Issues and PRs related to the stream subsystem.

Comments

@phated
Copy link
Contributor

phated commented Apr 25, 2018

  • Version:
    Node 10
  • Platform:
  • Subsystem:

Stream.pipeline doesn't re-emit errors when no callback is given. I opened this issue (mafintosh/pump#32) on pump before it was ported here but it was ignored.
@addaleax addaleax added the stream Issues and PRs related to the stream subsystem. label Apr 25, 2018
@addaleax addaleax changed the title Stream.pipeline shipped with a huge bug? Stream.pipeline does not re-emit errors without callback Apr 25, 2018
@addaleax
Copy link
Member

You already seem to have a PR for this, would you be willing to port that?

@phated
Copy link
Contributor Author

phated commented Apr 25, 2018

Yeah, I can try. I might have some time later today.

@phated
Copy link
Contributor Author

phated commented Apr 26, 2018

@addaleax working on a PR now but it seems that I can't run the test suite without xcode 😞

@addaleax
Copy link
Member

@phated If it would be easier for you if somebody else took this over at some point, I think that wouldn’t be an issue either

@phated phated mentioned this issue Apr 30, 2018
Closed
4 tasks
phated added a commit to phated/node that referenced this issue May 30, 2018
@phated
stream: ensure Stream.pipeline re-throws errors without callback
44d3fe3 
Fixes an issue where Stream.pipeline wouldn't re-throw errors
on a stream if no callback was specified, thus swallowing
said errors.

Fixes: nodejs#20303
addaleax pushed a commit that referenced this issue May 31, 2018
@phated @addaleax
stream: ensure Stream.pipeline re-throws errors without callback
d1e81b0 
Fixes an issue where Stream.pipeline wouldn't re-throw errors
on a stream if no callback was specified, thus swallowing
said errors.

Fixes: #20303

PR-URL: #20437
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: ensure Stream.pipeline re-emits errors without callback phated/node
2 participants
@addaleax @phated