We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe #19237 to be the culprit of this change.
I believe that PR unintentionally changed the behaviour of at least path.resolve which was not documented in the changelog.
path.resolve
We have a specific test around path.resolve and it started failing after 9.9.0 was released. See https://travis-ci.org/thelounge/thelounge/jobs/356475798#L582
https://github.com/thelounge/thelounge/blob/844ca1fbe602aa291b54085a6cf69198ea4a5390/test/src/helperTest.js#L14-L16
On 9.8.0 this happens:
> require("path").resolve("a\\b") '/home/xpaw/a\\b'
But on 9.9.0 it seems that separator is changed to the OS specific one.
> require("path").resolve("a\\b") '/home/xpaw/a/b'
The text was updated successfully, but these errors were encountered:
I have a fix ready. Just need to write tests.
Sorry, something went wrong.
path: fix regression in posix.normalize
3b978c6
Fixes a regression introduced in nodejs@4ae320f The posix version of normalize should not treat backslash as a path separator. Fixes: nodejs#19519
#19520
a0adf56
40916a2
Fixes a regression introduced in [1]. The posix version of normalize should not treat backslash as a path separator. [1] 4ae320f2 PR-URL: #19520 Fixes: #19519 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
No branches or pull requests
I believe #19237 to be the culprit of this change.
I believe that PR unintentionally changed the behaviour of at least
path.resolve
which was not documented in the changelog.We have a specific test around
path.resolve
and it started failing after 9.9.0 was released. See https://travis-ci.org/thelounge/thelounge/jobs/356475798#L582https://github.com/thelounge/thelounge/blob/844ca1fbe602aa291b54085a6cf69198ea4a5390/test/src/helperTest.js#L14-L16
On 9.8.0 this happens:
But on 9.9.0 it seems that separator is changed to the OS specific one.
The text was updated successfully, but these errors were encountered: