Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node --prrof-process fails: printErr not defined #19260

Closed
witt3rd opened this issue Mar 9, 2018 · 3 comments
Closed

node --prrof-process fails: printErr not defined #19260

witt3rd opened this issue Mar 9, 2018 · 3 comments

Comments

@witt3rd
Copy link

witt3rd commented Mar 9, 2018

  • Version: v9.8.0
  • Platform: macOS 10.3.3
  • Subsystem: profiling

Captured a profile session (node --profile) in a isolate-X.log file.

node --prof-process isolate-0x104001e00-v8.log > processed.txt
evalmachine.:2784
printErr(str);
^

ReferenceError: printErr is not defined
at TickProcessor.printError (evalmachine.:2784:3)
at TickProcessor.LogReader.processLog_ (evalmachine.:2536:12)
at TickProcessor.LogReader.processLogLine (evalmachine.:2419:10)
at TickProcessor.processLogFile (evalmachine.:2812:10)
at evalmachine.:3994:15
at internal/v8_prof_processor.js:41:28
at NativeModule.compile (bootstrap_node.js:654:7)
at Function.NativeModule.require (bootstrap_node.js:599:18)
at startup (bootstrap_node.js:140:20)
at bootstrap_node.js:666:3

targos pushed a commit that referenced this issue Mar 17, 2018
This commit moves the printErr() function, used by the
tick profiler processer, into the code string passed to
vm.runInThisContext().

PR-URL: #19285
Fixes: #19260
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 20, 2018
This commit moves the printErr() function, used by the
tick profiler processer, into the code string passed to
vm.runInThisContext().

PR-URL: #19285
Fixes: #19260
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
This commit moves the printErr() function, used by the
tick profiler processer, into the code string passed to
vm.runInThisContext().

PR-URL: nodejs#19285
Fixes: nodejs#19260
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@premnathj
Copy link

Facing the same issue...

addaleax pushed a commit that referenced this issue Sep 13, 2018
This commit moves the printErr() function, used by the
tick profiler processer, into the code string passed to
vm.runInThisContext().

PR-URL: #19285
Fixes: #19260
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@m-abs
Copy link

m-abs commented Sep 19, 2018

Seeing this on v8.12.0 too.

@richardlau
Copy link
Member

@m-abs See #22825 for v8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants