Deprecating lttng tracepoints. (and add alternative for linux if wanted) #18971
Comments
GlenTiki
added
c++
|
Cc @nodejs/diagnostics |
|
@thekemkid Do you know if the vanilla linux tracepoints support dynamic tracing names? With our new tracing point implementation we would like to support dynamic tracing points, such users can emit them too. For DTrace libusdt exists. |
|
@AndreasMadsen I think these are static tracepoints, but I may be wrong. I only started exploring them last night. |
|
Relevant PR: #18975 |
GlenTiki
added a commit
to GlenTiki/node
that referenced
this issue
Feb 25, 2018
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: nodejs#18971 Refs: nodejs#18975 Refs: nodejs#18945
GlenTiki
added a commit
that referenced
this issue
Mar 1, 2018
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: #18971 Refs: #18975 Refs: #18945 PR-URL: #18982 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
GlenTiki
added a commit
that referenced
this issue
Mar 1, 2018
PR-URL: #18982 Refs: #18971 Refs: #18975 Refs: #18945 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: nodejs#18971 Refs: nodejs#18975 Refs: nodejs#18945 PR-URL: nodejs#18982 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this issue
May 8, 2018
PR-URL: nodejs#18982 Refs: nodejs#18971 Refs: nodejs#18975 Refs: nodejs#18945 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Am I wrong to think this can be closed since #18982 landed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am proposing that we deprecate lttng tracepoints in favour of vanilla linux tracepoint support. I've started working on a POC for this personally.
I added lttng support way back in the day: #702
However, a PR has been opened recently that reveals building with lttng support has broken for over 2 years: #18945
And this is the commit that broke it: f1d2792 (June 28, 2016)
Very few people seem to use it or need it based on the above pr. The benefit of lttng is that when node is built with support for it, you can activate tracing your program from lttng without much overhead affecting it. It has been designed to be low enough overhead that you can run it in production to get useful information from the environment, if needed.
However, to build and use node with lttng support enabled, you need to be on linux with lttng installed on your system. There is not much value added to the general linux userbase because there is barrier of entry to using this that requires specific lttng knowledge.
If we added support for vanilla linux tracepoints, as @AndreasMadsen suggests here, lttng users can still consume these. By adding vanilla linux tracepoints, other alternative tracing tools should be able to use these new tracepoints too. Additionally we could consider beginning to compile node with support for these tracepoints enabled by default on linux.
The text was updated successfully, but these errors were encountered: