What branch/version and which of the contributing guides to use? #183
Comments
|
If I recall correctly, first on the roadmap is to make a edit: ooh, just missed the new and fancy |
|
Now that io.js is released we probably need to establish |
|
Stick to v1.x for the time being. |
This was referenced May 26, 2021
This was referenced Jul 21, 2021
This was referenced Jun 23, 2022
This was referenced Sep 26, 2022
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this issue
May 28, 2024
…odejs#183) Previously is was defined via soon-to-be-deprecated `v8::ObjectTemplate::SetAccessor(..)` which used to call setter even for property stores via stream object. The replacement V8 Api `v8::ObjectTemplate::SetNativeDataProperty(..)` defines a properly behaving data property and thus a store to a stream object will not trigger the "onread" setter callback. In order to preserve the desired behavior of storing the value in the receiver's internal field the "onread" property should be defined as a proper JavaScript accessor.
syg
pushed a commit
to syg/node
that referenced
this issue
Jun 20, 2024
…odejs#183) Previously is was defined via soon-to-be-deprecated `v8::ObjectTemplate::SetAccessor(..)` which used to call setter even for property stores via stream object. The replacement V8 Api `v8::ObjectTemplate::SetNativeDataProperty(..)` defines a properly behaving data property and thus a store to a stream object will not trigger the "onread" setter callback. In order to preserve the desired behavior of storing the value in the receiver's internal field the "onread" property should be defined as a proper JavaScript accessor. # Conflicts: # src/base_object-inl.h
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this issue
Aug 28, 2024
…odejs#183) Previously is was defined via soon-to-be-deprecated `v8::ObjectTemplate::SetAccessor(..)` which used to call setter even for property stores via stream object. The replacement V8 Api `v8::ObjectTemplate::SetNativeDataProperty(..)` defines a properly behaving data property and thus a store to a stream object will not trigger the "onread" setter callback. In order to preserve the desired behavior of storing the value in the receiver's internal field the "onread" property should be defined as a proper JavaScript accessor. # Conflicts: # src/base_object-inl.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is io.js working towards a 1.0.0 release? If so, can we do away with the v0.10/v0.12 branches and work from master, merge whatever's needed back into master?
The contributing guides are out of sync between the branches as well.
The text was updated successfully, but these errors were encountered: