Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-http-hightwatermark #17857

Closed
Trott opened this issue Dec 25, 2017 · 0 comments
Closed

Investigate flaky test-http-hightwatermark #17857

Trott opened this issue Dec 25, 2017 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX.

Comments

@Trott
Copy link
Member

Trott commented Dec 25, 2017 •
edited
Loading

  • Version: 10.0.0-pre
  • Platform: macOS
  • Subsystem: test

I've seen failures locally on my macOS laptop with make test of test-http-highwatermark. I'm able to reproduce it pretty easily with the right set of options:

$ tools/test.py -j 96 --repeat 192 test/parallel/test-http-hightwatermark.js 
=== release test-http-hightwatermark ===                    
Path: parallel/test-http-hightwatermark
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:496:10)
    at Server.<anonymous> (/Users/trott/io.js/test/parallel/test-http-hightwatermark.js:21:41)
    at Server.emit (events.js:131:13)
    at parserOnIncoming (_http_server.js:617:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:496:10)
    at Server.<anonymous> (/Users/trott/io.js/test/parallel/test-http-hightwatermark.js:28:43)
    at Server.emit (events.js:131:13)
    at parserOnIncoming (_http_server.js:617:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-hightwatermark.js
=== release test-http-hightwatermark ===                   
Path: parallel/test-http-hightwatermark
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:496:10)
    at Server.<anonymous> (/Users/trott/io.js/test/parallel/test-http-hightwatermark.js:21:41)
    at Server.emit (events.js:131:13)
    at parserOnIncoming (_http_server.js:617:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
    at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:496:10)
    at Server.<anonymous> (/Users/trott/io.js/test/parallel/test-http-hightwatermark.js:28:43)
    at Server.emit (events.js:131:13)
    at parserOnIncoming (_http_server.js:617:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-hightwatermark.js
[00:08|% 100|+ 190|-   2]: Done
$
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. labels Dec 25, 2017
@apapirovski apapirovski mentioned this issue Jan 2, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this issue Jan 8, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-highwatermark
8b9e478 
PR-URL: #17949
Fixes: #17857
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-highwatermark
d4e5ace 
PR-URL: #17949
Fixes: #17857
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-highwatermark
8806e54 
PR-URL: #17949
Fixes: #17857
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 24, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-highwatermark
1474a47 
PR-URL: #17949
Fixes: #17857
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-http-highwatermark apapirovski/node
1 participant
@Trott