Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify which module was requested in "SyntaxError: The requested module does not provide an export named '...'" #17785

Closed
dandv opened this issue Dec 20, 2017 · 2 comments
Closed

Specify which module was requested in "SyntaxError: The requested module does not provide an export named '...'" #17785

dandv opened this issue Dec 20, 2017 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs. esm Issues and PRs related to the ECMAScript Modules implementation.

Comments

@dandv
Copy link
Contributor

dandv commented Dec 20, 2017

I'm using --experimental-modules and find that when a module down the dependency chain doesn't export a symbol, it's hard to tell which module that was:

SyntaxError: The requested module does not provide an export named '...'

It would really help if Node included the name of the module that didn't provide that export.
@targos targos added confirmed-bug Issues with confirmed bugs. esm Issues and PRs related to the ECMAScript Modules implementation. labels Dec 20, 2017
@targos
Copy link
Member

targos commented Dec 20, 2017

This can be fixed the same way as #17277. I'm preparing a PR.

targos added a commit to targos/node that referenced this issue Dec 20, 2017
@targos
module: print better message on esm import error
f4dac9d 
Use the same approach as a previous PR to include the offending line in
the output and underline imports of inexistent exports.

Fixes: nodejs#17785
Refs: nodejs#17281
@targos targos mentioned this issue Dec 20, 2017
Closed
3 tasks
@targos
Copy link
Member

targos commented Dec 20, 2017

#17786

@targos targos closed this as completed in 359819e Dec 24, 2017
MylesBorins pushed a commit that referenced this issue Jan 8, 2018
@targos @MylesBorins
module: print better message on esm import error
83afd13 
Use the same approach as a previous PR to include the offending line in
the output and underline imports of inexistent exports.

PR-URL: #17786
Fixes: #17785
Refs: #17281
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@targos @MylesBorins
module: print better message on esm import error
d4d3ff4 
Use the same approach as a previous PR to include the offending line in
the output and underline imports of inexistent exports.

PR-URL: #17786
Fixes: #17785
Refs: #17281
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@targos @MylesBorins
module: print better message on esm import error
3b2d8cb 
Use the same approach as a previous PR to include the offending line in
the output and underline imports of inexistent exports.

PR-URL: #17786
Fixes: #17785
Refs: #17281
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dandv @targos