Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: intermitent failures in test-cluster-worker-disconnect #1757

Closed
santigimeno opened this issue May 21, 2015 · 3 comments
Closed

test: intermitent failures in test-cluster-worker-disconnect #1757

santigimeno opened this issue May 21, 2015 · 3 comments
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@santigimeno
Copy link
Member

From time to time the test is failing in a FreeBSD machine.

assert.js:88
  throw new assert.AssertionError({
        ^
AssertionError: Disconnect event did not emit
    at process.<anonymous> (/usr/home/sgimeno/node/io.js/test/parallel/test-cluster-worker-disconnect.js:84:12)
    at process.g (events.js:260:16)
    at emitOne (events.js:82:20)
    at process.emit (events.js:169:7)
    at process.exit (node.js:745:17)
    at /usr/home/sgimeno/node/io.js/test/parallel/test-cluster-worker-disconnect.js:74:15
    at doNTCallback0 (node.js:408:9)
    at process._tickCallback (node.js:337:13)
@mscdex mscdex added the test Issues and PRs related to the tests. label May 21, 2015
@Fishrock123
Copy link
Contributor

What versions? (freebsd, io.js...)

@santigimeno
Copy link
Member Author

FreeBSD 10.1
io.js from latest master

@brendanashworth brendanashworth added the freebsd Issues and PRs related to the FreeBSD platform. label May 22, 2015
@santigimeno santigimeno mentioned this issue Jun 8, 2015
Closed
brendanashworth pushed a commit that referenced this issue Jun 16, 2015
@santigimeno @brendanashworth
test: fix test-cluster-worker-disconnect
52a822d 
- Just let the process exit gracefully after the worker is disconnected.

Reviewed-By: Brendan Ashworth <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #1919
Fixes: #1757
@brendanashworth
Copy link
Contributor

This should be fixed as of 52a822d, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-cluster-worker-disconnect
4 participants
@mscdex @santigimeno @Fishrock123 @brendanashworth