http2: refactoring heads up

[jasnell]

@mcollina @addaleax @apapirovski @sebdeckers @nodejs/http2 ... just a general heads up... I'm in the process of a sizable internal refactoring of the http2 C/C++ internals. It's a combination of long standing clean up, a number of necessary performance optimizations to reduce the number of memcpy's, and a cleanup of some of the internal buffering code. The internals are going to look quite a bit different by the time I'm done on this. It will likely take me a day or two.

[addaleax]

btw, #16461 is pretty much good to go, I’ll kick off CI in a bit & land if it comes back green, so it might be helpful to work off that :)

[jasnell]

Dang... forgot about that one and I'm already a fair bit down the road. Ok, let me know once that it landed and I'll rebase around it. Much of the changes I'm looking at will actually supersede much of that one as I am moving quite a few pieces around.

[addaleax]

@jasnell done!

[jasnell]

After going through this for a few days, the changes I had in mind are just too significant of a change right now. There are also a few things that still need to be figured out in order to pull it off appropriately. I'm going to take a step back and figure out a more incremental approach.

[grantila]

@jasnell keep #11552 in mind, please have a look at my comment about being able to detach http sockets. Since #16256, we can (re-)attach a socket to http1 or http2, but we might need to also provide a head buffer when constructing an Http2Session for "http1 upgrade" to work.

[apapirovski]

@jasnell Is there any other work in progress other than the PRs? I'm planning to take a look at some of the C++ code this week but don't want us to step on each other's toes.

[jasnell]

Yeah I have a few more bits to work on. What parts are you looking at? On Nov 1, 2017 14:06, "Anatoli Papirovski" <[email protected]> wrote: @jasnell <https://github.com/jasnell> Is there any other work in progress other than the PRs? I'm planning to take a look at that some of the C++ code this week but don't want to step on each other's toes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16624 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2eWDa_lrxmexjG9OmvRYBLf3F1l0aks5syN1qgaJpZM4QLzwM> .

[addaleax]

@jasnell What's the status on this one? :)

[jasnell]

In progress. Decided to split over multiple PRs. I've opened several up to this point, preparing another now.

[jasnell]

This was done.