Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: intercept what headers are being sent #16619

Closed
mcollina opened this issue Oct 30, 2017 · 2 comments
Closed

http2: intercept what headers are being sent #16619

mcollina opened this issue Oct 30, 2017 · 2 comments
Labels
http2 Issues or PRs related to the http2 subsystem.

Comments

@mcollina
Copy link
Member

  • Version: master, 8.8.1
  • Platform: all
  • Subsystem: http2

In http2 client API is not currently possible to know which headers are being sent. The actual headers that have been sent should be kept somewhere for debugging/introspection purposes.
@mcollina mcollina added the http2 Issues or PRs related to the http2 subsystem. label Oct 30, 2017
@kasimdoctor
Copy link

@mcollina I would like to help on this. Is there a possibility of working with a mentor or someone who is familiar with this module?

@mcollina
Copy link
Member Author

mcollina commented Nov 2, 2017

@jasnell @apapirovski @sebdeckers or myself. However just tag @nodejs/http2 in your PR.
You can also find me on node-dev on IRC.

@jasnell jasnell mentioned this issue Jan 8, 2018
Closed
4 tasks
jasnell added a commit to jasnell/node that referenced this issue Jan 11, 2018
@jasnell
http2: remember sent headers
fae7328 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

Fixes: nodejs#16619
evanlucas pushed a commit that referenced this issue Jan 30, 2018
@jasnell @evanlucas
http2: remember sent headers
eee40c7 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

PR-URL: #18045
Fixes: #16619
Reviewed-By: Matteo Collina <[email protected]>
kjin pushed a commit to kjin/node that referenced this issue May 1, 2018
@jasnell @kjin
http2: remember sent headers
1d5ab00 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

PR-URL: nodejs#18045
Fixes: nodejs#16619
Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this issue May 2, 2018
@jasnell @MylesBorins
http2: remember sent headers
a4d910c 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

Backport-PR-URL: #20456
PR-URL: #18045
Fixes: #16619
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @kasimdoctor