Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: inconsistent initial of expected in TypeError[ERR_INVALID_ARG_TYPE] #16383

Closed
starkwang opened this issue Oct 22, 2017 · 2 comments
Closed

lib: inconsistent initial of expected in TypeError[ERR_INVALID_ARG_TYPE] #16383

starkwang opened this issue Oct 22, 2017 · 2 comments
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.

Comments

@starkwang
Copy link
Contributor

The initials of expected in TypeError[ERR_INVALID_ARG_TYPE] are inconsistent. Some codes are using uppercase for primitive types and some are using lowercase:

For example, uppercase:
https://github.com/nodejs/node/blob/master/lib/_tls_common.js#L61
https://github.com/nodejs/node/blob/master/lib/internal/child_process.js#L295

Lowercase :
https://github.com/nodejs/node/blob/master/lib/buffer.js#L201
https://github.com/nodejs/node/blob/master/lib/fs.js#L1865

It‘s a little bit of chaos. Should we unify them?

  • Version: master
  • Platform: all
  • Subsystem: internal/errors, lib
@addaleax addaleax added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Oct 22, 2017
@addaleax
Copy link
Member

Lowercase array seems like a bug here, thanks for catching that!

Generally, we should try to do the same thing the documentation does; use lowercase for primitive types, uppercase for classes.

@starkwang
Copy link
Contributor Author

@addaleax What about function? It is not primitive type but we are using 'function'.

@starkwang starkwang mentioned this issue Oct 23, 2017
Closed
3 tasks
evanlucas pushed a commit that referenced this issue Nov 13, 2017
@starkwang @evanlucas
lib: improve the usage of TypeError[INVALID_ARG_TYPE]
c179254 
The initials of expected in TypeError[ERR_INVALID_ARG_TYPE]
are inconsistent. This change is to unify them.

PR-URL: #16401
Fixes: #16383
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@starkwang starkwang mentioned this issue Dec 9, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib: improve the usage of TypeError[INVALID_ARG_TYPE] starkwang/node
2 participants
@addaleax @starkwang