Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: DEBUG build with clang in FreeBSD fails #1608

Closed
santigimeno opened this issue May 4, 2015 · 3 comments · Fixed by #1609
Closed

build: DEBUG build with clang in FreeBSD fails #1608

santigimeno opened this issue May 4, 2015 · 3 comments · Fixed by #1609
Labels
build Issues and PRs related to build files or the CI.

Comments

@santigimeno
Copy link
Member

Output:

gmake[1]: Entering directory '/usr/home/sgimeno/node/io.js/out'
  c++ '-DDEBUG' '-D_DEBUG' -I../deps/gtest -I../deps/gtest/include  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -Wno-missing-field-initializers -g -Og -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /usr/home/sgimeno/node/io.js/out/Debug/.deps//usr/home/sgimeno/node/io.js/out/Debug/obj.target/gtest/deps/gtest/src/gtest-death-test.o.d.raw  -c -o /usr/home/sgimeno/node/io.js/out/Debug/obj.target/gtest/deps/gtest/src/gtest-death-test.o ../deps/gtest/src/gtest-death-test.cc
error: invalid integral value 'g' in '-Og'
error: invalid integral value 'g' in '-Og'

clang version:

FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512

It looks like clang does not support debug-safe optimizations with -Og introduced in #1569. See: https://llvm.org/bugs/show_bug.cgi?id=20765. Some workarounds are proposed there.
@Fishrock123 Fishrock123 added the build Issues and PRs related to build files or the CI. label May 4, 2015
@Fishrock123
Copy link
Contributor

This doesn't seem so good.

@bnoordhuis maybe we can make it an option to use -Og?

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 4, 2015
@bnoordhuis
build: disable -Og when building with clang
f9ea440 
clang does not yet support -Og, fall back to -O0.

Fixes: nodejs#1608
See: https://llvm.org/bugs/show_bug.cgi?id=20765
@bnoordhuis bnoordhuis mentioned this issue May 4, 2015
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 4, 2015
@bnoordhuis
build: disable -Og when building with clang
e67542a 
clang does not yet support -Og, fall back to -O0.

See: https://llvm.org/bugs/show_bug.cgi?id=20765
Fixes: nodejs#1608
PR-URL: nodejs#1609
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@bnoordhuis
Copy link
Member

Fixed by e67542a.

@santigimeno
Copy link
Member Author

Still getting the same error. It looks like the clang variable is not set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: disable -Og when building with clang bnoordhuis/io.js
3 participants
@bnoordhuis @santigimeno @Fishrock123