Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixtures/listen-on-socket-and-exit needs improved cleanup #1543

Closed
jbergstroem opened this issue Apr 28, 2015 · 2 comments
Closed

fixtures/listen-on-socket-and-exit needs improved cleanup #1543

jbergstroem opened this issue Apr 28, 2015 · 2 comments
Labels
test Issues and PRs related to the tests.

Comments

@jbergstroem
Copy link
Member

While reviewing some of our buildbots, I've found some dead processes which all seems related to failing this test. We need to make cleanup more robust.
@jbergstroem jbergstroem added the test Issues and PRs related to the tests. label Apr 28, 2015
@jbergstroem
Copy link
Member Author

Just reminding myself that this still seems to be an issue. Found a stray process on one of the smartos machines that's been running from July 2nd (roughly one week). Edit: and one on a freebsd machine.

@thefourtheye thefourtheye mentioned this issue Jul 19, 2015
Closed
thefourtheye added a commit to thefourtheye/io.js that referenced this issue Jul 30, 2015
@thefourtheye
test: handling failure cases properly
584c40b 
Refer: nodejs#1543

When this test fails, it leaves dead processes in the system. This
patch makes sure that the child processes exit first, in case of
errors.
thefourtheye added a commit that referenced this issue Aug 27, 2015
@thefourtheye
test: handling failure cases properly
bdef668 
Refer: #1543

When this test fails, it leaves dead processes in the system. This
patch makes sure that the child processes exit first, in case of
errors.

PR-URL: #2206
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@thefourtheye
Copy link
Contributor

Hope #2206 fixed it. Closing for now.

thefourtheye added a commit that referenced this issue Aug 28, 2015
@thefourtheye @rvagg
test: handling failure cases properly
5e65181 
Refer: #1543

When this test fails, it leaves dead processes in the system. This
patch makes sure that the child processes exit first, in case of
errors.

PR-URL: #2206
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@snyk-bot snyk-bot mentioned this issue Jul 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbergstroem @thefourtheye