http2: Change in respondWithFile api not properly reflected in the docs #15390
Comments
mscdex
added
http2
|
I can update http2 documentation, I found where I have to change the text. I will submit a PR soon with few updates. |
4 tasks
antoine-amara
added a commit
to antoine-amara/node
that referenced
this issue
Sep 26, 2017
http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake. Add a description to have more informations when onError is triggered. Fixes: nodejs#15390
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this issue
Sep 28, 2017
http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake. Add a description to have more informations when onError is triggered. PR-URL: nodejs#15501 Fixes: nodejs#15390 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Sep 29, 2017
http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake. Add a description to have more informations when onError is triggered. PR-URL: #15501 Fixes: #15390 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this issue
Sep 30, 2017
http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake. Add a description to have more informations when onError is triggered. PR-URL: nodejs/node#15501 Fixes: nodejs/node#15390 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Oct 3, 2017
http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake. Add a description to have more informations when onError is triggered. PR-URL: #15501 Fixes: #15390 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Oct 3, 2017
http2stream.respondWithFile api has changed since 8.5.0 with the addition of the onError option. In the first code example an onError function is implemented but never used, fix this mistake. Add a description to have more informations when onError is triggered. PR-URL: #15501 Fixes: #15390 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
respondWithFileapi has changed between 8.4.0 and 8.5.0 with the addition of the onError option. This is important, because a simpleresponse.stream.on('error'...no longer works after this change because the steam gets destroyed on an error (in particular on ENOENT) ifonErrordoesn't exist so any attempt to resend a different file then crashes with stream undefined.However the docs, although creating an
onErrorfunction in the example then doesn't actually use it on the call torespondWithFileThe text was updated successfully, but these errors were encountered: