-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exceptions in inspector callback cause fatal error #14965
Labels
inspector
Issues and PRs related to the V8 inspector protocol
Comments
/cc @nodejs/v8-inspector |
This is caused by having a console.log statement that triggers inspector notification after the exception. I will take a look. |
3 tasks
MylesBorins
pushed a commit
that referenced
this issue
Sep 10, 2017
Fixes: #14965 PR-URL: #14980 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Sep 11, 2017
Fixes: #14965 PR-URL: #14980 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Sep 12, 2017
Fixes: #14965 PR-URL: #14980 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this issue
Sep 13, 2017
Fixes: nodejs#14965 PR-URL: nodejs#14980 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An exception (either with "throw" or due to an error) inside the callback from an inspector event sometimes causes a fatal error (if there is not a fatal, it appears to eat the exception)
Possibly same issue as #12024
This case seems to reliably trigger it:
output:
The text was updated successfully, but these errors were encountered: