Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: http.ClientRequest "timeout" event missing #14856

Closed
kanongil opened this issue Aug 16, 2017 · 1 comment
Closed

Docs: http.ClientRequest "timeout" event missing #14856

kanongil opened this issue Aug 16, 2017 · 1 comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@kanongil
Copy link
Contributor

The setTimeout() documentation mentions an undocumented "timeout" event.

Same as binding to the timeout event
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Aug 16, 2017
@jesboom
Copy link

jesboom commented Aug 24, 2017

This "timeout" event is very simple and wellknown event.
And if you refer to the document's request.setTimeout (timeout [, callback]) section,
you can see the document for the "timeout" event

**request.setTimeout(timeout[, callback])
-timeout {number} Milliseconds before a request is considered to be timed out.
-callback {Function} Optional function to be called when a timeout occurs. Same as binding to the timeout event.

lpinca added a commit to lpinca/node that referenced this issue Sep 17, 2017
@lpinca
doc: add documentation for the 'timeout' event
ee04c21 
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

Fixes: nodejs#14856
@lpinca lpinca mentioned this issue Sep 17, 2017
Closed
2 tasks
jasnell pushed a commit that referenced this issue Sep 20, 2017
@lpinca @jasnell
doc: add documentation for the 'timeout' event
7fa2bee 
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: #15443
Fixes: #14856
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@lpinca
doc: add documentation for the 'timeout' event
2caa47d 
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: nodejs/node#15443
Fixes: nodejs/node#14856
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@lpinca
doc: add documentation for the 'timeout' event
d0b1af2 
Adds the `'timeout'` event to the `http.ClientRequest` documentation.

PR-URL: nodejs/node#15443
Fixes: nodejs/node#14856
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add documentation for the 'timeout' event lpinca/node
3 participants
@kanongil @vsemozhetbyt @jesboom