Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,windows: vcbuild.bat should try to detect location of python.exe #13882

Closed
refack opened this issue Jun 22, 2017 · 3 comments · Fixed by #13900
Closed

build,windows: vcbuild.bat should try to detect location of python.exe #13882

refack opened this issue Jun 22, 2017 · 3 comments · Fixed by #13900
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. wip Issues and PRs that are still a work in progress.

Comments

@refack
Copy link
Contributor

refack commented Jun 22, 2017 •
edited
Loading

  • Version: *
  • Platform: Windows
  • Subsystem: build

Ref: nodejs/CTC#147 (comment)

vcbuild.bat requires python for proper operation. Currently it assumes python.exe is in the path. There is a standard way to query the windows registry for the install location of python PEP-0514, vcbuild.bat should implement it.
@refack refack added build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. windows Issues and PRs related to the Windows platform. labels Jun 22, 2017
This was referenced Jun 22, 2017
Closed
Closed
@benjamingr
Copy link
Member

@refack won't that standard way only work with Python 3?

@refack
Copy link
Contributor Author

refack commented Jun 22, 2017

@refack won't that standard way only work with Python 3?

No. The python2 windows installer has been doing it for a long time, the PEP was made ad-hoc.

@tniessen
Copy link
Member

This might become pretty ugly in Windows batch...

@refack refack mentioned this issue Jun 24, 2017
Merged
2 tasks
@refack refack added wip Issues and PRs that are still a work in progress. and removed good first issue Issues that are suitable for first-time contributors. labels Jun 24, 2017
@refack refack self-assigned this Jun 24, 2017
refack added a commit to refack/node that referenced this issue Jun 28, 2017
@refack
build,windows: implement PEP514 python detection
614dbbd 
PR-URL: nodejs#13900
Fixes: nodejs#13882
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this issue Jun 29, 2017
@refack @addaleax
build,windows: implement PEP514 python detection
00a0b39 
PR-URL: #13900
Fixes: #13882
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this issue Jul 11, 2017
@refack @addaleax
build,windows: implement PEP514 python detection
49d542d 
PR-URL: #13900
Fixes: #13882
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this issue Jul 18, 2017
@refack @addaleax
build,windows: implement PEP514 python detection
949f7be 
PR-URL: #13900
Fixes: #13882
Reviewed-By: Tobias Nießen <[email protected]>
refack added a commit to refack/node that referenced this issue Aug 15, 2017
@refack
build,windows: implement PEP514 python detection
5663961 
PR-URL: nodejs#13900
Fixes: nodejs#13882
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Aug 16, 2017
@refack @MylesBorins
build,windows: implement PEP514 python detection
162bc81 
Backport-PR-URL: #14842
PR-URL: #13900
Fixes: #13882
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 5, 2017
@refack @MylesBorins
build,windows: implement PEP514 python detection
2a1a93d 
Backport-PR-URL: #14842
PR-URL: #13900
Fixes: #13882
Reviewed-By: Tobias Nießen <[email protected]>
@refack refack removed their assignment Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build,windows: Implement python detection refack/node
3 participants
@refack @benjamingr @tniessen