Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--max-executable-size not recognized after upgrade 7.10.0 => 8.0.0 #13341

Closed
abenhamdine opened this issue May 31, 2017 · 4 comments
Closed

--max-executable-size not recognized after upgrade 7.10.0 => 8.0.0 #13341

abenhamdine opened this issue May 31, 2017 · 4 comments
Labels
cli Issues and PRs related to the Node.js command line interface. v8 engine Issues and PRs related to the V8 dependency.

Comments

@abenhamdine
Copy link

abenhamdine commented May 31, 2017

  • Version:8.0.0
  • Platform:Windows 10 64bits
  • Subsystem: child process

The following code doesn't crash with node 7.10.0 but crashes with node 8.0.0 :

            const env = _.cloneDeep(process.env);

            const options = {
                execArgv: process.execArgv.concat(['--expose-gc', '--max-executable-size=384', '--max-old-space-size=512', '--max-semi-space-size=2']),
                env: env
            };

            const cp = child_process.fork(myPathProcess, [someArg1, someArg2], options);

The error :

C:\Program Files\nodejs\node.exe: bad option: --max-executable-size=384

DEBUG 19:38:55 : Calculation.onChildExit() : child process 7016 exited with code 9

I've suspected #12348 but failed to see how it can be related.

Have the V8 options changed ? I didn't find anything in the changelog about this.
Or is --max-executable-size the correct syntax ?

@mscdex mscdex added cli Issues and PRs related to the Node.js command line interface. v8 engine Issues and PRs related to the V8 dependency. v8.x labels May 31, 2017
@targos
Copy link
Member

targos commented May 31, 2017

This flag was removed in #13217 (commit).

@silverwind
Copy link
Contributor

The new option for that should be --max_old_space_size.

@abenhamdine
Copy link
Author

abenhamdine commented May 31, 2017

Ah thx a lot for the quick and precise answer !
Shouldn't it be in the changelog for 8.0.0 ?
Seems pretty common case to use this flag.

@bnoordhuis
Copy link
Member

V8 flags come and go, we don't normally call them out in the release notes. I'll go ahead and close this.

edouard-lopez added a commit to parlr/ruby-font-creator that referenced this issue Feb 24, 2018
> node: bad option: --max_executable_size=4096

cf. --max-executable-size not recognized after upgrade 7.10.0 => 8.0.0 #13341
nodejs/node#13341
edouard-lopez added a commit to parlr/ruby-font-creator that referenced this issue Feb 26, 2018
> node: bad option: --max_executable_size=4096

cf. --max-executable-size not recognized after upgrade 7.10.0 => 8.0.0 #13341
nodejs/node#13341
hugolpz pushed a commit to parlr/ruby-font-creator that referenced this issue Feb 26, 2018
> node: bad option: --max_executable_size=4096

cf. --max-executable-size not recognized after upgrade 7.10.0 => 8.0.0 #13341
nodejs/node#13341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

5 participants