[8.0.0] v8.Serializer crashes on bad input

[gireeshpunathil]

• Version: v8.0.0
• Platform: mac, Darwin xnu-3248.30.4~1/RELEASE_X86_64 x86_64
• Subsystem: v8

#node -e "require('v8').Serializer()"
/usr/local/bin/node[52273]: ../src/base-object-inl.h:80:void node::BaseObject::MakeWeak(Type *) [Type = node::(anonymous namespace)::SerializerContext]: Assertion `(handle->InternalFieldCount()) > (0)' failed.
 1: node::Abort() [/usr/local/bin/node]
 2: node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, char const*, int, v8::Local<v8::Value>*, double, double) [/usr/local/bin/node]
 3: node::(anonymous namespace)::SerializerContext::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node]
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/usr/local/bin/node]
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node]
 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
 7: 0x1b2d558437d
Abort trap: 6

Expectation is to handle this in JS code itself.

[addaleax]

Thanks – this isn’t really bad input to the serializer, it’s the Serializer class requiring to be called with new. I can fix this later today or tomorrow, unless somebody else wants to.

[gireeshpunathil]

thanks @addaleax !

[zimbabao]

@addaleax : I tried to fix it, let me know if that not a proper fix.

[addaleax]

Sorry, kind of forgot about this one. Thank you!