Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHATWG URL throw parse error for valid domains #12965

Closed
zimbabao opened this issue May 11, 2017 · 1 comment
Closed

WHATWG URL throw parse error for valid domains #12965

zimbabao opened this issue May 11, 2017 · 1 comment
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label May 11, 2017
@TimothyGu
Copy link
Member

On the spec side of things: This is a known issue of the URL Standard and Unicode Technical Standard UTS#46 (which specifies IDNA processing used by WHATWG's standard). A fix to UTS#46 is scheduled to be released in tandem with Unicode 10.0.0 next month. See:

On the implementation side, a future ICU4C update with the possibility to disable the CheckHyphens flag will resolve this, but a solution like #12966 which uses existing error handling infrastructure should be robust also (already used for several other error conditions we explicitly filter out).

@domenic domenic mentioned this issue May 11, 2017
zimbabao added a commit to zimbabao/node that referenced this issue May 15, 2017
To match browser behavior fast path ascii only domains and
do not run ToASCII on them.

Fixes: nodejs#12965
Refs: nodejs#12966
Refs: whatwg/url#309
zimbabao added a commit to zimbabao/node that referenced this issue May 15, 2017
To match browser behavior fast path ascii only domains and
do not run ToASCII on them.

Fixes: nodejs#12965
Refs: nodejs#12966
Refs: whatwg/url#309
zimbabao added a commit to zimbabao/node that referenced this issue May 15, 2017
To match browser behavior fast path ascii only domains and
do not run ToASCII on them.

Fixes: nodejs#12965
Refs: nodejs#12966
Refs: whatwg/url#309
zimbabao added a commit to zimbabao/node that referenced this issue May 15, 2017
To match browser behavior fast path ascii only domains and
do not run ToASCII on them.

Fixes: nodejs#12965
Refs: nodejs#12966
Refs: whatwg/url#309
zimbabao added a commit to zimbabao/node that referenced this issue May 15, 2017
To match browser behavior fast path ascii only domains and
do not run ToASCII on them.

Fixes: nodejs#12965
Refs: nodejs#12966
Refs: whatwg/url#309
zimbabao added a commit to zimbabao/node that referenced this issue May 16, 2017
To match browser behavior fast path ascii only domains and
do not run ToASCII on them.

Fixes: nodejs#12965
Refs: nodejs#12966
Refs: whatwg/url#309
zimbabao added a commit to zimbabao/node that referenced this issue May 19, 2017
There are valid domain names with hyphens at 3 and 4th position, new
node WHATWG URL parser was failing for it assume its an invalid IDN.

Fixes: nodejs#12965
zimbabao added a commit to zimbabao/node that referenced this issue May 19, 2017
There are valid domain names with hyphens at 3 and 4th position, new
node WHATWG URL parser was failing for it assume its an invalid IDN.
Also filters IDN errors when domain label start or end with hyphen.

Fixes: nodejs#12965
Refs: https://www.icann.org/news/announcement-2000-01-07-en
zimbabao added a commit to zimbabao/node that referenced this issue May 19, 2017
There are valid domain names with hyphens at 3 and 4th position, new
node WHATWG URL parser was failing for it assume its an invalid IDN.
Also filters IDN errors when domain label start or end with hyphen.

Fixes: nodejs#12965
Refs: https://www.icann.org/news/announcement-2000-01-07-en
zimbabao added a commit to zimbabao/node that referenced this issue May 19, 2017
There are valid domain names with hyphens at 3 and 4th position, new
node WHATWG URL parser was failing for it assume its an invalid IDN.
Also filters IDN errors when domain label start or end with hyphen.

Also fix error in ToUnicode

Fixes: nodejs#12965
Refs: https://www.icann.org/news/announcement-2000-01-07-en
Refs: whatwg/url#309 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
3 participants