Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: is parallel/test-https-client-get-url flaky on macOS #12873

Closed
refack opened this issue May 6, 2017 · 5 comments
Closed

test: is parallel/test-https-client-get-url flaky on macOS #12873

refack opened this issue May 6, 2017 · 5 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. https Issues or PRs related to the https subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.

Comments

@refack
Copy link
Contributor

refack commented May 6, 2017

  • Version: master
  • Platform: macOS
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-osx/9598/nodes=osx1010/

655	parallel/test-https-client-get-url	
duration_ms	
0.315
severity	
fail
stack	
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: connect ECONNREFUSED 127.0.0.1:51636
    at Object.exports._errnoException (util.js:1026:11)
    at exports._exceptionWithHostPort (util.js:1049:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1115:14)

/cc @nodejs/platform-macos
@refack refack added macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. labels May 6, 2017
@mscdex mscdex added the https Issues or PRs related to the https subsystem. label May 6, 2017
@sebastianplesciuc
Copy link

Could this cause the issue? There are 3 gets and server.close() is called for each of them.

@refack
Copy link
Contributor Author

refack commented May 6, 2017

Could this cause the issue? There are 3 gets and server.close() is called for each of them.

Which bring up the question, how did this ever work 😕 probablyy the 3 gets are buffered and the server has to deal with them before the 3 callback get to server.close())

@sebastianplesciuc
Copy link

Can I call dibs on trying to fix it?

@refack
Copy link
Contributor Author

refack commented May 6, 2017

Of course. (good thing you did).

@refack refack assigned refack and unassigned refack May 6, 2017
@sebastianplesciuc sebastianplesciuc mentioned this issue May 6, 2017
Closed
3 tasks
refack pushed a commit to refack/node that referenced this issue May 10, 2017
@refack
test: fix flaky test-https-client-get-url
317180f 
Fixed test-https-client-get-url by waiting on HTTPS GET requests
to finish before closing the server.

PR-URL: nodejs#12876
Fixes: nodejs#12873
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@refack
Copy link
Contributor Author

refack commented May 10, 2017

Fixed by: #12876

@refack refack closed this as completed May 10, 2017
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
test: fix flaky test-https-client-get-url
078e28d 
Fixed test-https-client-get-url by waiting on HTTPS GET requests
to finish before closing the server.

PR-URL: nodejs#12876
Fixes: nodejs#12873
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@sebastianplesciuc sebastianplesciuc mentioned this issue Jun 7, 2017
Closed
@BridgeAR BridgeAR added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. https Issues or PRs related to the https subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @refack @BridgeAR @sebastianplesciuc