Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/update-authors.sh doesn't work on OSX #1120

Closed
rvagg opened this issue Mar 10, 2015 · 3 comments
Closed

tools/update-authors.sh doesn't work on OSX #1120

rvagg opened this issue Mar 10, 2015 · 3 comments
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@rvagg
Copy link
Member

rvagg commented Mar 10, 2015

If someone has the time to shave this yak it would be greatly appreciated.

The update-authors.sh script works fine on Linux but not on OSX where the file gets jumbled. I believe the problem is that the OSX version of awk doesn't maintain natural sorting like the Linux one does. This is frustrating for me since I split my time between my OSX and Linux computers but can only run this on Linux.

-1 to rewriting this in JavaScript btw, I'd like to see a scripting solution, preferably with minimal changes to the existing script, although I don't know if that's even possible.
@rvagg rvagg added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Mar 10, 2015
@bnoordhuis
Copy link
Member

I think I've spotted a gawk-ism in there. I'll take a look.

@brendanashworth
Copy link
Contributor

+1, had this same issue once.

@bnoordhuis bnoordhuis mentioned this issue Mar 11, 2015
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Mar 11, 2015
@bnoordhuis
doc: make tools/update-authors.sh cross-platform
d33a647 
And by cross-platform I mean Linux and OS X.  The awk script is not
compatible with BSD awk, that's why this commit changes it to perl.

Update the .mailmap to remove some duplicates and regenerate the
AUTHORS file.

Fixes: nodejs#1120
PR-URL: nodejs#1121
Reviewed-By: Rod Vagg <[email protected]>
@bnoordhuis
Copy link
Member

Fixed by d33a647.

@MaxMood96 MaxMood96 mentioned this issue Jun 22, 2023
Open
@baby636 baby636 mentioned this issue Jun 22, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Jun 22, 2023
Open
@leonardoadame leonardoadame mentioned this issue Jul 7, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Nov 27, 2023
Open
@ryan-ally ryan-ally mentioned this issue Nov 27, 2023
Open
@baby636 baby636 mentioned this issue Nov 28, 2023
Open
@MaxMood96 MaxMood96 mentioned this issue Nov 28, 2023
Open
@aliscco aliscco mentioned this issue Nov 30, 2023
Open
@leonardoadame leonardoadame mentioned this issue Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this issue Dec 19, 2023
Open
@ryan-ally ryan-ally mentioned this issue Dec 19, 2023
Open
@baby636 baby636 mentioned this issue Dec 20, 2023
Open
This was referenced Dec 20, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnoordhuis @rvagg @brendanashworth