Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent parallel/test-http-regr-gh-2821 failure on V6.9.2 (Windows) #10286

Closed
Akpotohwo opened this issue Dec 15, 2016 · 10 comments · Fixed by #12698
Closed

Intermittent parallel/test-http-regr-gh-2821 failure on V6.9.2 (Windows) #10286

Akpotohwo opened this issue Dec 15, 2016 · 10 comments · Fixed by #12698
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@Akpotohwo
Copy link

Version: 6.9.2
Platform: 32-bit (Win2012)

=== release test-http-regr-gh-2821 ===
Path: parallel/test-http-regr-gh-2821
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at exports._errnoException (util.js:1022:11)
    at TCP.onread (net.js:569:26)
Command: C:\node\node\out\Release\node.exe C:\node\node\test\parallel\test-http-regr-gh-2821.js

We're seeing this failure intermittently on Windows.

@gibfahn
Copy link
Member

gibfahn commented Dec 15, 2016

@nodejs/platform-windows

@gibfahn gibfahn added the windows Issues and PRs related to the Windows platform. label Dec 15, 2016
@addaleax addaleax added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Dec 15, 2016
@Trott
Copy link
Member

Trott commented Dec 15, 2016

FWIW, there is at least one existing "tolerate ECONNRESET on Windows" workarounds in our tests:

if (common.isWindows) {
s.on('error', function(err) {
// Prevent possible ECONNRESET errors from popping up
if (err.code !== 'ECONNRESET')
throw err;
});
}

If the cause gets sorted out for this file, maybe the workaround can be removed from that one.

@bzoz
Copy link
Contributor

bzoz commented Apr 24, 2017

@Akpotohwo are you running the tests inside a virtual machine?

@Akpotohwo
Copy link
Author

@bzoz Yes I am

@Akpotohwo Akpotohwo reopened this Apr 25, 2017
@refack
Copy link
Contributor

refack commented Apr 27, 2017

Another sighting: #12621 (comment)

23	parallel/test-child-process-fork-regr-gh-2847	
duration_ms	
0.313
severity	
fail
stack	
c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vcbt2015\label\win10\test\parallel\test-child-process-fork-regr-gh-2847.js:61
            throw err;
            ^

Error: write EMFILE
    at exports._errnoException (util.js:1026:11)
    at ChildProcess.target._send (internal/child_process.js:663:20)
    at ChildProcess.target.send (internal/child_process.js:547:19)
    at Worker.send (internal/cluster/worker.js:54:28)
    at Socket.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vcbt2015\label\win10\test\parallel\test-child-process-fork-regr-gh-2847.js:33:14)
    at Object.onceWrapper (events.js:312:19)
    at emitNone (events.js:105:13)
    at Socket.emit (events.js:207:7)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1102:10)

FWIW https://ci.nodejs.org/job/node-test-binary-windows/8042/RUN_SUBSET=1,VS_VERSION=vcbt2015,label=win10/ (I don't know how long there are cached)

@gibfahn
Copy link
Member

gibfahn commented May 11, 2017

@refack that looks like a different test (parallel/test-http-regr-gh-2821 vs
parallel/test-child-process-fork-regr-gh-2847)

@refack
Copy link
Contributor

refack commented May 11, 2017

@refack that looks like a different test (parallel/test-http-regr-gh-2821 vs
parallel/test-child-process-fork-regr-gh-2847)

As far as I recall the underlying problem was suggested to be the same #3635 (comment)

refack added a commit to refack/node that referenced this issue May 19, 2017
According to the explanation in nodejs#3635#issuecomment-157714683
And as a continuation to nodejs#5422 we also ignore EMFILE
"No more file descriptors are available,so no more files can be opened"

PR-URL: nodejs#12698
Fixes: nodejs#10286
Refs: nodejs#3635 (comment)
Refs: nodejs#5178
Refs: nodejs#5179
Refs: nodejs#4005
Refs: nodejs#5121
Refs: nodejs#5422
Refs: nodejs#12621 (comment)
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this issue Jul 17, 2017
According to the explanation in #3635#issuecomment-157714683
And as a continuation to #5422 we also ignore EMFILE
"No more file descriptors are available,so no more files can be opened"

PR-URL: #12698
Fixes: #10286
Refs: #3635 (comment)
Refs: #5178
Refs: #5179
Refs: #4005
Refs: #5121
Refs: #5422
Refs: #12621 (comment)
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented Sep 8, 2017

I don't think #12698 fixed this, as @gireeshpunathil mentions in #3635 (comment) , there are three errors, #12698 fixes the EMFILE one. I'm still seeing this locally.

@gibfahn gibfahn reopened this Sep 8, 2017
@maclover7 maclover7 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 25, 2017
@Trott
Copy link
Member

Trott commented Oct 18, 2018

This test no longer exists. (It has probably been renamed.) Closing.

@Trott Trott closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants