stream: change stream to use index instead of for...of

PR-URL: #54474 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Aug 30, 2024 · fffc300 · fffc300
1 parent b584356
commit fffc300
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/stream.js b/lib/stream.js
@@ -61,7 +61,9 @@ Stream.isReadable = utils.isReadable;
 Stream.isWritable = utils.isWritable;
 
 Stream.Readable = require('internal/streams/readable');
-for (const key of ObjectKeys(streamReturningOperators)) {
+const streamKeys = ObjectKeys(streamReturningOperators);
+for (let i = 0; i < streamKeys.length; i++) {
+  const key = streamKeys[i];
   const op = streamReturningOperators[key];
   function fn(...args) {
     if (new.target) {
@@ -79,7 +81,9 @@ for (const key of ObjectKeys(streamReturningOperators)) {
     writable: true,
   });
 }
-for (const key of ObjectKeys(promiseReturningOperators)) {
+const promiseKeys = ObjectKeys(promiseReturningOperators);
+for (let i = 0; i < promiseKeys.length; i++) {
+  const key = promiseKeys[i];
   const op = promiseReturningOperators[key];
   function fn(...args) {
     if (new.target) {