workflow: adjust github env for ubsan options

nodejs · Mar 2, 2024 · f989175 · f989175
1 parent c803294
commit f989175
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/.github/workflows/test-ubsan.yml b/.github/workflows/test-ubsan.yml
@@ -44,23 +44,21 @@ jobs:
       CXX: g++
       LINK: g++
       CONFIG_FLAGS: --enable-ubsan
+      UBSAN_OPTIONS: "$GITHUB_WORKSPACE/suppressions.supp:print_stacktrace=1"
     steps:
       - uses: actions/checkout@v3
         with:
           persist-credentials: false
-      - name: Store suppressions path
+      - name: Debug
         run: |
-          echo "UBSAN_OPTIONS=$GITHUB_WORKSPACE/suppressions.supp:print_stacktrace=1" >> $GITHUB_ENV
+          echo "$UBSAN_OPTIONS"
       - name: Set up Python ${{ env.PYTHON_VERSION }}
         uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
-      - name: Check UBSAN_OPTIONS
-        run: |
-          echo $UBSAN_OPTIONS
-      # - name: Environment Information
-      #   run: npx envinfo
-      # - name: Build
-      #   run: make build-ci -j2 V=1
-      # - name: Test
-      #   run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions -t 300 --measure-flakiness 9"
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: make build-ci -j2 V=1
+      - name: Test
+        run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions -t 300 --measure-flakiness 9"
diff --git a/suppressions.supp b/suppressions.supp
@@ -1,4 +1,3 @@
-deps/icu-small/*
 vptr:deps/icu-small/source/common/uloc_tag.cpp
 vptr:deps/icu-small/source/common/unistr.cpp
 shift-base:deps/v8/src/wasm/decoder.h