stream: allow using .push()/.unshift() during once('data')

Previously, the `.push()` or `.unshift()` call would just have jumped straight to emitting a `'data'` event, even if there were no listeners, effectively just silently dropping the chunk. PR-URL: #34957 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
nodejs · Sep 1, 2020 · f537c86 · f537c86
1 parent 94c6e09
commit f537c86
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -292,7 +292,8 @@ function readableAddChunk(stream, chunk, encoding, addToFront) {
 }
 
 function addChunk(stream, state, chunk, addToFront) {
-  if (state.flowing && state.length === 0 && !state.sync) {
+  if (state.flowing && state.length === 0 && !state.sync &&
+      stream.listenerCount('data') > 0) {
     // Use the guard to avoid creating `Set()` repeatedly
     // when we have multiple pipes.
     if (state.multiAwaitDrain) {

diff --git a/test/parallel/test-stream-readable-add-chunk-during-data.js b/test/parallel/test-stream-readable-add-chunk-during-data.js
@@ -0,0 +1,21 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const { Readable } = require('stream');
+
+// Verify that .push() and .unshift() can be called from 'data' listeners.
+
+for (const method of ['push', 'unshift']) {
+  const r = new Readable({ read() {} });
+  r.once('data', common.mustCall((chunk) => {
+    assert.strictEqual(r.readableLength, 0);
+    r[method](chunk);
+    assert.strictEqual(r.readableLength, chunk.length);
+
+    r.on('data', common.mustCall((chunk) => {
+      assert.strictEqual(chunk.toString(), 'Hello, world');
+    }));
+  }));
+
+  r.push('Hello, world');
+}