src,test: update snapshot failure in node.cc and associated test

nodejs · Feb 19, 2023 · f4f6b6b · f4f6b6b
1 parent 7b22b42
commit f4f6b6b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -1181,8 +1181,7 @@ ExitCode LoadSnapshotDataAndRun(const SnapshotData** snapshot_data_ptr,
     FILE* fp = fopen(filename.c_str(), "rb");
     if (fp == nullptr) {
       fprintf(stderr, "Cannot open %s", filename.c_str());
-      // TODO(joyeecheung): should be kStartupSnapshotFailure.
-      exit_code = ExitCode::kGenericUserError;
+      exit_code = ExitCode::kStartupSnapshotFailure;
       return exit_code;
     }
     std::unique_ptr<SnapshotData> read_data = std::make_unique<SnapshotData>();

diff --git a/test/parallel/test-snapshot-error.js b/test/parallel/test-snapshot-error.js
@@ -47,7 +47,7 @@ const entry = fixtures.path('snapshot', 'error.js');
   console.log(child.status);
   console.log(stderr);
   console.log(child.stdout.toString());
-  assert.strictEqual(child.status, 1);
+  assert.strictEqual(child.status, 14);
   assert.match(stderr, /Cannot open/);
   assert(!fs.existsSync(path.join(tmpdir.path, 'snapshot.blob')));
 }