http: there is no corked property of stream

Do not check/use unexistent property, use `OutgoingMessage` instead. PR-URL: #18325 Reviewed-By: Mithun Sasidharan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jan 27, 2018 · f29c2cb · f29c2cb
1 parent 287f21e
commit f29c2cb
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -38,6 +38,8 @@ const errors = require('internal/errors');
 const { CRLF, debug } = common;
 const { utcDate } = internalHttp;
 
+const kIsCorked = Symbol('isCorked');
+
 var RE_FIELDS =
   /^(?:Connection|Transfer-Encoding|Content-Length|Date|Expect|Trailer|Upgrade)$/i;
 var RE_CONN_VALUES = /(?:^|\W)close|upgrade(?:$|\W)/ig;
@@ -99,6 +101,7 @@ function OutgoingMessage() {
 
   this.finished = false;
   this._headerSent = false;
+  this[kIsCorked] = false;
 
   this.socket = null;
   this.connection = null;
@@ -648,9 +651,10 @@ function write_(msg, chunk, encoding, callback, fromEnd) {
   // signal the user to keep writing.
   if (chunk.length === 0) return true;
 
-  if (!fromEnd && msg.connection && !msg.connection.corked) {
+  if (!fromEnd && msg.connection && !msg[kIsCorked]) {
     msg.connection.cork();
-    process.nextTick(connectionCorkNT, msg.connection);
+    msg[kIsCorked] = true;
+    process.nextTick(connectionCorkNT, msg, msg.connection);
   }
 
   var len, ret;
@@ -679,7 +683,8 @@ function writeAfterEndNT(err, callback) {
 }
 
 
-function connectionCorkNT(conn) {
+function connectionCorkNT(msg, conn) {
+  msg[kIsCorked] = false;
   conn.uncork();
 }