src: Handle bad callback in asyc_wrap

Align with the MaybeLocal<> API contract PR-URL: #31946 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 17, 2020 · eaa730c · eaa730c
1 parent db9857d
commit eaa730c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/async_wrap-inl.h b/src/async_wrap-inl.h
@@ -74,9 +74,8 @@ inline v8::MaybeLocal<v8::Value> AsyncWrap::MakeCallback(
   if (!object()->Get(env()->context(), symbol).ToLocal(&cb_v))
     return v8::MaybeLocal<v8::Value>();
   if (!cb_v->IsFunction()) {
-    // TODO(addaleax): We should throw an error here to fulfill the
-    // `MaybeLocal<>` API contract.
-    return v8::MaybeLocal<v8::Value>();
+    v8::Isolate* isolate = env()->isolate();
+    return Undefined(isolate);
   }
   return MakeCallback(cb_v.As<v8::Function>(), argc, argv);
 }