lib: replace spread operator with primordials function

replaced the spread operator with ArrayPrototypeSlice to avoid reliance on user-mutable methods and enhance the safety of array iteration Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration PR-URL: #54053 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
nodejs · Aug 14, 2024 · ea0a60c · ea0a60c
1 parent 10f3254
commit ea0a60c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/internal/streams/compose.js b/lib/internal/streams/compose.js
@@ -1,5 +1,9 @@
 'use strict';
 
+const {
+  ArrayPrototypeSlice,
+} = primordials;
+
 const { pipeline } = require('internal/streams/pipeline');
 const Duplex = require('internal/streams/duplex');
 const { destroyer } = require('internal/streams/destroy');
@@ -30,7 +34,7 @@ module.exports = function compose(...streams) {
     return Duplex.from(streams[0]);
   }
 
-  const orgStreams = [...streams];
+  const orgStreams = ArrayPrototypeSlice(streams);
 
   if (typeof streams[0] === 'function') {
     streams[0] = Duplex.from(streams[0]);