build: compile with C++20 support

PR-URL: #52838 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
nodejs · May 8, 2024 · e4b1874 · e4b1874
1 parent 8fbf662
commit e4b1874
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -171,7 +171,7 @@ endif
 with-code-cache test-code-cache:
 	$(warning '$@' target is a noop)
 
-out/Makefile: config.gypi common.gypi node.gyp \
+out/Makefile: config.gypi common.gypi common_node.gypi node.gyp \
 	deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \
 	deps/simdutf/simdutf.gyp deps/ada/ada.gyp \
 	tools/v8_gypfiles/toolchain.gypi tools/v8_gypfiles/features.gypi \

diff --git a/common_node.gypi b/common_node.gypi
@@ -0,0 +1,16 @@
+{
+  'target_defaults': {
+    'conditions': [
+      # Override common.gypi config to use C++20 for Node.js core only.
+      ['OS in "linux freebsd openbsd solaris android aix os400 cloudabi"', {
+        'cflags_cc!': ['-std=gnu++17'],
+        'cflags_cc': ['-std=gnu++20'],
+      }],
+      ['OS=="mac" and clang==1', {
+        'xcode_settings': {
+          'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++20',  # -std=gnu++20
+        },
+      }],
+    ],
+  },
+}
diff --git a/node.gyp b/node.gyp
@@ -862,6 +862,7 @@
         '<@(deps_files)',
         # node.gyp is added by default, common.gypi is added for change detection
         'common.gypi',
+        'common_node.gypi',
       ],
 
       'variables': {
@@ -1349,6 +1350,7 @@
             '<@(library_files)',
             '<@(deps_files)',
             'common.gypi',
+            'common_node.gypi',
           ],
           'direct_dependent_settings': {
             'ldflags': [ '-Wl,-brtl' ],

diff --git a/tools/create_android_makefiles b/tools/create_android_makefiles
@@ -37,6 +37,7 @@ export GYP_DEFINES
 
 ./deps/npm/node_modules/node-gyp/gyp/gyp \
     -Icommon.gypi \
+    -Icommon_node.gypi \
     -Iconfig.gypi \
     --depth=. \
     -Dcomponent=static_library \

diff --git a/tools/gyp_node.py b/tools/gyp_node.py
@@ -20,11 +20,15 @@ def run_gyp(args):
   a_path = node_root if sys.platform == 'win32' else os.path.abspath(node_root)
   args.append(os.path.join(a_path, 'node.gyp'))
   common_fn = os.path.join(a_path, 'common.gypi')
+  common_node_fn = os.path.join(a_path, 'common_node.gypi')
   options_fn = os.path.join(a_path, 'config.gypi')
 
   if os.path.exists(common_fn):
     args.extend(['-I', common_fn])
 
+  if os.path.exists(common_node_fn):
+    args.extend(['-I', common_node_fn])
+
   if os.path.exists(options_fn):
     args.extend(['-I', options_fn])