fixup! fs: improve error performance for fs.mkdtempSync

nodejs · Sep 24, 2023 · e2ea13a · e2ea13a
1 parent 476e8d4
commit e2ea13a
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/benchmark/fs/bench-mkdtempSync.js b/benchmark/fs/bench-mkdtempSync.js
@@ -28,11 +28,20 @@ function main({ n, type }) {
   bench.start();
   for (let i = 0; i < n; i++) {
     try {
-      const folderPath = fs.mkdtempSync(prefix, { encoding: 'utf8' });
-      fs.rmdirSync(folderPath);
+      fs.mkdtempSync(`${prefix}-${i}`, { encoding: 'utf8' });
     } catch {
       // do nothing
     }
   }
   bench.end(n);
+
+  if (type === 'valid') {
+    for (let i = 0; i < n; i++) {
+      try {
+        fs.rmdirSync(`${prefix}-${i}`);
+      } catch {
+        // do nothing
+      }
+    }
+  }
 }