tls: tls_wrap causes debug assert in vector

When using a debug build (on Windows specifically) the error case for tls_wrap causes an assert to fire because the index being passed is outside the bounds of the vector. The fix is to switch to iterators. PR-URL: #18830 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Feb 21, 2018 · e05ecaa · e05ecaa
1 parent fe8cfc3
commit e05ecaa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc
@@ -518,8 +518,8 @@ bool TLSWrap::ClearIn() {
     // This can be skipped in the error case because no further writes
     // would succeed anyway.
     pending_cleartext_input_.insert(pending_cleartext_input_.end(),
-                                    &buffers[i],
-                                    &buffers[buffers.size()]);
+                                    buffers.begin() + i,
+                                    buffers.end());
   }
 
   return false;