fixup! fixup! test,debugger: migrate node-inspect tests to core

nodejs · Apr 9, 2021 · dce5476 · dce5476
1 parent 0675754
commit dce5476
Show file tree

Hide file tree

Showing 16 changed files with 32 additions and 0 deletions.
diff --git a/test/inspector-cli/test-inspector-cli-backtrace.js b/test/inspector-cli/test-inspector-cli-backtrace.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-break.js b/test/inspector-cli/test-inspector-cli-break.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-clear-breakpoints.js b/test/inspector-cli/test-inspector-cli-clear-breakpoints.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-exceptions.js b/test/inspector-cli/test-inspector-cli-exceptions.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-exec-scope.js b/test/inspector-cli/test-inspector-cli-exec-scope.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/backtrace.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-exec.js b/test/inspector-cli/test-inspector-cli-exec.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/alive.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-heap-profiler.js b/test/inspector-cli/test-inspector-cli-heap-profiler.js
@@ -19,6 +19,8 @@ const filename = 'node.heapsnapshot';
   const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-help.js b/test/inspector-cli/test-inspector-cli-help.js
@@ -12,6 +12,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-low-level.js b/test/inspector-cli/test-inspector-cli-low-level.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const scriptPattern = /^\* (\d+): \S+inspector-cli(?:\/|\\)three-lines\.js/m;
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-preserve-breaks.js b/test/inspector-cli/test-inspector-cli-preserve-breaks.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-profile.js b/test/inspector-cli/test-inspector-cli-profile.js
@@ -17,6 +17,8 @@ function delay(ms) {
   const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-run-after-quit-restart.js b/test/inspector-cli/test-inspector-cli-run-after-quit-restart.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-sb-before-load.js b/test/inspector-cli/test-inspector-cli-sb-before-load.js
@@ -20,6 +20,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-scripts.js b/test/inspector-cli/test-inspector-cli-scripts.js
@@ -14,6 +14,8 @@ const assert = require('assert');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-use-strict.js b/test/inspector-cli/test-inspector-cli-use-strict.js
@@ -14,6 +14,8 @@ const assert = require('assert');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

diff --git a/test/inspector-cli/test-inspector-cli-watchers.js b/test/inspector-cli/test-inspector-cli-watchers.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/break.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }