worker: spin uv_run twice before closing loop

On Windows, the Platform’s `uv_async_t` may need two iterations before closing when it was previously in use. Refs: #26089 Refs: #26006 PR-URL: #26138 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Feb 28, 2019 · dab64bb · dab64bb
1 parent d550de4
commit dab64bb
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/node_worker.cc b/src/node_worker.cc
@@ -150,7 +150,10 @@ class WorkerThreadData {
 
     isolate->Dispose();
 
-    // Need to run the loop one more time to close the platform's uv_async_t
+    // Need to run the loop twice more to close the platform's uv_async_t
+    // TODO(addaleax): It would be better for the platform itself to provide
+    // some kind of notification when it has fully cleaned up.
+    uv_run(&loop_, UV_RUN_ONCE);
     uv_run(&loop_, UV_RUN_ONCE);
 
     CheckedUvLoopClose(&loop_);