async_wrap: fix memory leak in AsyncResource

Reset the persistent that keeps the resource Object alive when the AsyncResource is being destroyed. Fixes: nodejs/node-addon-api#237 PR-URL: #20668 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 9, 2018 · d7d5f11 · d7d5f11
1 parent 6eec3fc
commit d7d5f11
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/node.h b/src/node.h
@@ -735,6 +735,7 @@ class AsyncResource {
 
     virtual ~AsyncResource() {
       EmitAsyncDestroy(isolate_, async_context_);
+      resource_.Reset();
     }
 
     v8::MaybeLocal<v8::Value> MakeCallback(