deps: v8: record dynamic import call without import assertsions

nodejs · Nov 23, 2022 · d731a0e · d731a0e
1 parent 6582d98
commit d731a0e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/deps/v8/src/execution/execution.cc b/deps/v8/src/execution/execution.cc
@@ -114,7 +114,6 @@ InvokeParams InvokeParams::SetUpForCall(Isolate* isolate,
   params.receiver = NormalizeReceiver(isolate, receiver);
   // Check for host-defined options argument for scripts.
   DCHECK_IMPLIES(params.IsScript(), argc == 1);
-  DCHECK_IMPLIES(params.IsScript(), argv[0]->IsFixedArray());
   params.argc = argc;
   params.argv = argv;
   params.new_target = isolate->factory()->undefined_value();
@@ -137,7 +136,6 @@ InvokeParams InvokeParams::SetUpForTryCall(
   params.receiver = NormalizeReceiver(isolate, receiver);
   // Check for host-defined options argument for scripts.
   DCHECK_IMPLIES(params.IsScript(), argc == 1);
-  DCHECK_IMPLIES(params.IsScript(), argv[0]->IsFixedArray());
   params.argc = argc;
   params.argv = argv;
   params.new_target = isolate->factory()->undefined_value();
@@ -338,7 +336,6 @@ V8_WARN_UNUSED_RESULT MaybeHandle<Object> Invoke(Isolate* isolate,
       DCHECK(params.IsScript());
       DCHECK(params.receiver->IsJSGlobalProxy());
       DCHECK_EQ(params.argc, 1);
-      DCHECK(params.argv[0]->IsFixedArray());
     } else {
       DCHECK(!params.IsScript());
     }

diff --git a/deps/v8/src/parsing/parser-base.h b/deps/v8/src/parsing/parser-base.h
@@ -3735,8 +3735,8 @@ ParserBase<Impl>::ParseImportExpressions() {
   AcceptINScope scope(this, true);
   ExpressionT specifier = ParseAssignmentExpressionCoverGrammar();
 
+  impl()->scope()->RecordInnerScopeCallsDynamicImport();
   if (v8_flags.harmony_import_assertions && Check(Token::COMMA)) {
-    impl()->scope()->RecordInnerScopeCallsDynamicImport();
     if (Check(Token::RPAREN)) {
       // A trailing comma allowed after the specifier.
       return factory()->NewImportCallExpression(specifier, pos);