Skip to content

Commit

Permalink
doc: do not create a backup file
Browse files Browse the repository at this point in the history
The `sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h`
command creates a `zconf.h--` backup file on macOS. Replace it with an
equivalent perl one-liner so that it works on both Linux and macOS.

PR-URL: #47151
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
lpinca authored and RafaelGSS committed Apr 13, 2023
1 parent e7ca09f commit d56c0f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/contributing/maintaining-zlib.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ mv zlib deps/
mv deps/zlib.gyp deps/GN-scraper.py deps/zlib/
mkdir deps/zlib/win32
mv deps/zlib.def deps/zlib/win32
sed -i -- 's_^#include "chromeconf.h"_//#include "chromeconf.h"_' deps/zlib/zconf.h
perl -i -pe 's|^#include "chromeconf.h"|//#include "chromeconf.h"|' deps/zlib/zconf.h
```

Check that Node.js still builds and tests.
Expand Down

0 comments on commit d56c0f7

Please sign in to comment.