use ArrayPrototypeForEach instead of SafeArrayIterator

Co-authored-by: Antoine du Hamel <[email protected]>
nodejs · Jan 11, 2021 · d4373f8 · d4373f8
1 parent 932e4bf
commit d4373f8
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/internal/per_context/primordials.js b/lib/internal/per_context/primordials.js
@@ -172,6 +172,7 @@ function copyPrototype(src, dest, prefix) {
 /* eslint-enable node-core/prefer-primordials */
 
 const {
+  ArrayPrototypeForEach,
   FunctionPrototypeCall,
   Map,
   ObjectFreeze,
@@ -212,24 +213,23 @@ primordials.SafeStringIterator = createSafeIterator(
   primordials.StringIteratorPrototypeNext
 );
 
-const { SafeArrayIterator } = primordials;
 const copyProps = (src, dest) => {
-  for (const key of new SafeArrayIterator(ReflectOwnKeys(src))) {
+  ArrayPrototypeForEach(ReflectOwnKeys(src), (key) => {
     if (!ReflectGetOwnPropertyDescriptor(dest, key)) {
       ReflectDefineProperty(
         dest,
         key,
         ReflectGetOwnPropertyDescriptor(src, key));
     }
-  }
+  });
 };
 
 const makeSafe = (unsafe, safe) => {
   if (SymbolIterator in unsafe.prototype) {
     const dummy = new unsafe();
     let next; // We can reuse the same `next` method.
 
-    for (const key of new SafeArrayIterator(ReflectOwnKeys(unsafe.prototype))) {
+    ArrayPrototypeForEach(ReflectOwnKeys(unsafe.prototype), (key) => {
       if (!ReflectGetOwnPropertyDescriptor(safe.prototype, key)) {
         const desc = ReflectGetOwnPropertyDescriptor(unsafe.prototype, key);
         if (
@@ -246,7 +246,7 @@ const makeSafe = (unsafe, safe) => {
         }
         ReflectDefineProperty(safe.prototype, key, desc);
       }
-    }
+    });
   } else {
     copyProps(unsafe.prototype, safe.prototype);
   }