Skip to content

Commit

Permalink
src: disable vector ICs on arm
Browse files Browse the repository at this point in the history
A bug on ARMv6 makes the process crash when the V8 debugger is used.
Disabling vector ICs as a workaround.

V8-Bug: https://code.google.com/p/v8/issues/detail?id=4338
PR-URL: #2220
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
  • Loading branch information
targos authored and rvagg committed Aug 4, 2015
1 parent 3d3c687 commit d200932
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3657,6 +3657,11 @@ void Init(int* argc,
// TODO(bnoordhuis): Remove test/parallel/test-arm-math-exp-regress-1376.js
// and this workaround when v8:4019 has been fixed and the patch back-ported.
V8::SetFlagsFromString("--nofast_math", sizeof("--nofast_math") - 1);
// See https://github.com/nodejs/io.js/pull/2220#issuecomment-126200059
// and https://code.google.com/p/v8/issues/detail?id=4338
// TODO(targos): Remove this workaround when v8:4338 has been fixed and the
// patch back-ported.
V8::SetFlagsFromString("--novector_ics", sizeof("--novector_ics") - 1);
#endif

#if defined(NODE_V8_OPTIONS)
Expand Down

0 comments on commit d200932

Please sign in to comment.