-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tls,http2: handle writes after SSL destroy more gracefully
This might otherwise result in a hard crash when trying to write to a socket after a sudden disconnect. Note that the test here uses an aborted `h2load` run to create the failing requests; That’s far from ideal, but it provides a reasonably reliably reproduction at this point.
- Loading branch information
Showing
2 changed files
with
38 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
|
||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
|
||
const child_process = require('child_process'); | ||
const http2 = require('http2'); | ||
const fs = require('fs'); | ||
|
||
const key = fixtures.readKey('agent8-key.pem', 'binary'); | ||
const cert = fixtures.readKey('agent8-cert.pem', 'binary'); | ||
|
||
const server = http2.createSecureServer({ key, cert }, (request, response) => { | ||
fs.createReadStream(process.execPath).pipe(response); | ||
}); | ||
|
||
// This should be doable with a reproduction purely written in Node; | ||
// that just requires somebody to take the time and actually do it. | ||
server.listen(0, () => { | ||
const proc = child_process.spawn('h2load', [ | ||
'-n', '1000', | ||
`https://localhost:${server.address().port}/` | ||
]); | ||
proc.on('error', (err) => { | ||
if (err.code === 'ENOENT') | ||
common.skip('no h2load'); | ||
}); | ||
proc.on('exit', () => server.close()); | ||
setTimeout(() => proc.kill(2), 100); | ||
}); |