fixup: apply the review

Signed-off-by: Daeyeon Jeong [email protected]
nodejs · Jul 13, 2022 · cecfa5f · cecfa5f
1 parent 036ad32
commit cecfa5f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/src/js_native_api_v8.cc b/src/js_native_api_v8.cc
@@ -2457,9 +2457,9 @@ napi_status NAPI_CDECL napi_check_object_type_tag(napi_env env,
         *result =
             (tag.lower == type_tag->lower && tag.upper == type_tag->upper);
       } else if (size == 1) {
-        *result = (tag.lower == type_tag->lower);
+        *result = (tag.lower == type_tag->lower && 0 == type_tag->upper);
       } else if (size == 0) {
-        *result = (type_tag->lower == 0 && type_tag->upper == 0);
+        *result = (0 == type_tag->lower && 0 == type_tag->upper);
       }
     }
   }

diff --git a/test/js-native-api/test_object/test.js b/test/js-native-api/test_object/test.js
@@ -175,6 +175,11 @@ assert.strictEqual(newObject.test_string, 'test string');
   // Verify that wrongly tagged objects are rejected.
   assert.strictEqual(test_object.CheckTypeTag(0, obj2), false);
   assert.strictEqual(test_object.CheckTypeTag(1, obj1), false);
+  assert.strictEqual(test_object.CheckTypeTag(0, obj3), false);
+  assert.strictEqual(test_object.CheckTypeTag(1, obj4), false);
+  assert.strictEqual(test_object.CheckTypeTag(2, obj4), false);
+  assert.strictEqual(test_object.CheckTypeTag(3, obj3), false);
+  assert.strictEqual(test_object.CheckTypeTag(4, obj3), false);
 
   // Verify that untagged objects are rejected.
   assert.strictEqual(test_object.CheckTypeTag(0, {}), false);

diff --git a/test/js-native-api/test_object/test_object.c b/test/js-native-api/test_object/test_object.c
@@ -605,11 +605,12 @@ static napi_value TestSeal(napi_env env,
 }
 
 // We create two type tags. They are basically 128-bit UUIDs.
-static const napi_type_tag type_tags[4] = {
+static const napi_type_tag type_tags[5] = {
   { 0xdaf987b3cc62481a, 0xb745b0497f299531 },
   { 0xbb7936c374084d9b, 0xa9548d0762eeedb9 },
   { 0xa5ed9ce2e4c00c38, 0 },
   { 0, 0 },
+  { 0xa5ed9ce2e4c00c38, 0xdaf987b3cc62481a },
 };
 
 static napi_value