stream: remove ambiguous code

PR-URL: #29664 Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Sep 29, 2019 · ce62e96 · ce62e96
1 parent dd74b16
commit ce62e96
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/internal/streams/end-of-stream.js b/lib/internal/streams/end-of-stream.js
@@ -59,25 +59,23 @@ function eos(stream, opts, callback) {
     };
   }
 
-  let readable = opts.readable ||
+  const readable = opts.readable ||
     (opts.readable !== false && isReadable(stream));
-  let writable = opts.writable ||
+  const writable = opts.writable ||
     (opts.writable !== false && isWritable(stream));
 
   const onlegacyfinish = () => {
     if (!stream.writable) onfinish();
   };
 
   const onfinish = () => {
-    writable = false;
     writableFinished = true;
-    if (!readable) callback.call(stream);
+    if (!readable || readableEnded) callback.call(stream);
   };
 
   const onend = () => {
-    readable = false;
     readableEnded = true;
-    if (!writable) callback.call(stream);
+    if (!writable || writableFinished) callback.call(stream);
   };
 
   const onclose = () => {