Skip to content

Commit

Permalink
build: reconfigure when gyp files change on Windows
Browse files Browse the repository at this point in the history
Previously only changes to .gypi files trigger a reconfigure
on Windows.

PR-URL: #39066
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
  • Loading branch information
joyeecheung authored and richardlau committed Jul 19, 2021
1 parent d0c7ab0 commit cabb458
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ if defined projgen goto run-configure
if not exist node.sln goto run-configure
if not exist .gyp_configure_stamp goto run-configure
echo %configure_flags% > .tmp_gyp_configure_stamp
where /R . /T *.gyp? >> .tmp_gyp_configure_stamp
where /R . /T *.gyp* >> .tmp_gyp_configure_stamp
fc .gyp_configure_stamp .tmp_gyp_configure_stamp >NUL 2>&1
if errorlevel 1 goto run-configure

Expand All @@ -354,7 +354,7 @@ if not exist node.sln goto create-msvs-files-failed
set project_generated=1
echo Project files generated.
echo %configure_flags% > .gyp_configure_stamp
where /R . /T *.gyp? >> .gyp_configure_stamp
where /R . /T *.gyp* >> .gyp_configure_stamp

:msbuild
@rem Skip build if requested.
Expand Down

0 comments on commit cabb458

Please sign in to comment.