src: check empty before accessing string

Fix an assertion when running dotnev tests with GN build: assertion !empty() failed: string::front(): string is empty which was caused by calling value.front() without verifying the value is not empty. PR-URL: #51665 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
nodejs · Feb 16, 2024 · c682fbf · c682fbf
1 parent ec3c7bc
commit c682fbf
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/node_dotenv.cc b/src/node_dotenv.cc
@@ -116,11 +116,11 @@ void Dotenv::ParseContent(const std::string_view content) {
     value.erase(0, value.find_first_not_of(" \t"));
 
     // Remove trailing whitespaces
-    value.erase(value.find_last_not_of(" \t") + 1);
-
-    const char maybeQuote = value.front();
+    if (!value.empty()) {
+      value.erase(value.find_last_not_of(" \t") + 1);
+    }
 
-    if (maybeQuote == '"') {
+    if (!value.empty() && value.front() == '"') {
       value = std::regex_replace(value, std::regex("\\\\n"), "\n");
       value = std::regex_replace(value, std::regex("\\\\r"), "\r");
     }